You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/02 22:16:58 UTC
[GitHub] [superset] pabrahamusa opened a new issue #12900: Hide tool Bar for SQLLab Tab broken 1.0
pabrahamusa opened a new issue #12900:
URL: https://github.com/apache/superset/issues/12900
A clear and concise description of what the bug is.
### Expected results
When you have multiple tabs , Hide Tool Bar should appear for all 'Expanded' Tabs
### Actual results
When you have multiple tabs, Hide tool Bar will only work for first tab. All remaining tab will still display Expand Tool Bar. which is incorrect .
#### Screenshots
In this image you can see that it is not displaying 'Hide tool Bar' . Instead it is showing 'Expand Tool Bar'..!
#### How to reproduce the bug
1. Go to 'SQLLab'
2. Create couple of New Tabs by clicking +
3. Go to one of the Tab and Click on the three dots on the left side of tab head and choose "hide Tool Bar' from the drop down.
4. Go to a different tab try to do the same.
5. You can see 'Hide Tool Bar' is not displaying for all other tabs.
### Environment
(please complete the following information):
- superset version: 1.0 (Docker image build from master v1.0.0)
```
root@sb-superset-666fdfc5db-c6l7l:/app# superset version
Loaded your LOCAL configuration at [/app/pythonpath/superset_config.py]
logging was configured successfully
INFO:superset.utils.logging_configurator:logging was configured successfully
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Superset 0.999.0dev
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
```
- python version:
```
root@sb-superset-666fdfc5db-c6l7l:/app# python --version
Python 3.7.9
```
- node.js version: `node -v`
```
root@sb-superset-666fdfc5db-c6l7l:/app# node -v
bash: node: command not found
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph closed issue #12900: Hide tool Bar for SQLLab Tab broken 1.0
Posted by GitBox <gi...@apache.org>.
yousoph closed issue #12900:
URL: https://github.com/apache/superset/issues/12900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on issue #12900: Hide tool Bar for SQLLab Tab broken 1.0
Posted by GitBox <gi...@apache.org>.
yousoph commented on issue #12900:
URL: https://github.com/apache/superset/issues/12900#issuecomment-772113554
Thanks for reporting, I'm seeing the issue on master (hide toolbar, switch to a tab with an expanded toolbar, click to try to hide the toolbar in the new tab)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on issue #12900: Hide tool Bar for SQLLab Tab broken 1.0
Posted by GitBox <gi...@apache.org>.
yousoph commented on issue #12900:
URL: https://github.com/apache/superset/issues/12900#issuecomment-949336222
Can't repro anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12900: Hide tool Bar for SQLLab Tab broken 1.0
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12900:
URL: https://github.com/apache/superset/issues/12900#issuecomment-772050718
tested on master by creating 10 tabs, clicked all Hide tool bar on all tabs, seems working properly.
however, please do checkout master yet as we discovered some severe regression. please expect fixes in patch release @pabrahamusa
https://user-images.githubusercontent.com/67837651/106670707-4001eb00-6562-11eb-8fd1-72e391dfe2cb.mov
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on issue #12900: Hide tool Bar for SQLLab Tab broken 1.0
Posted by GitBox <gi...@apache.org>.
yousoph commented on issue #12900:
URL: https://github.com/apache/superset/issues/12900#issuecomment-772113554
Thanks for reporting, I'm seeing the issue on master (hide toolbar, switch to a tab with an expanded toolbar, click to try to hide the toolbar in the new tab)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12900: Hide tool Bar for SQLLab Tab broken 1.0
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12900:
URL: https://github.com/apache/superset/issues/12900#issuecomment-772050718
tested on master by creating 10 tabs, clicked all Hide tool bar on all tabs, seems working properly.
however, please do checkout master yet as we discovered some severe regression. please expect fixes in patch release @pabrahamusa
https://user-images.githubusercontent.com/67837651/106670707-4001eb00-6562-11eb-8fd1-72e391dfe2cb.mov
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org