You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/08/02 09:34:02 UTC
[GitHub] [camel] orpiske opened a new pull request, #8095: CAMEL-17947 + CAMEL-18327
orpiske opened a new pull request, #8095:
URL: https://github.com/apache/camel/pull/8095
This fixes 2 small but related issues:
- CAMEL-17947: remove unnecessary consumer close
- CAMEL-18327: remove unnecessary consumer unsubscription
We probably need to backport these to 3.18 and (I guess) 3.14.
<!-- Uncomment and fill this section if your PR is not trivial
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske merged pull request #8095: CAMEL-17947 + CAMEL-18327
Posted by GitBox <gi...@apache.org>.
orpiske merged PR #8095:
URL: https://github.com/apache/camel/pull/8095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8095: CAMEL-17947 + CAMEL-18327
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8095:
URL: https://github.com/apache/camel/pull/8095#issuecomment-1202251764
:warning: This PR changes Camel components and will be tested automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #8095: CAMEL-17947 + CAMEL-18327
Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #8095:
URL: https://github.com/apache/camel/pull/8095#issuecomment-1202348668
The test failure here is somewhat related to the test failing in #8086 (both are related to the commit handling). We can merge this and that one, and I'll take a closer look at why these tests are behaving like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8095: CAMEL-17947 + CAMEL-18327
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8095:
URL: https://github.com/apache/camel/pull/8095#issuecomment-1202312546
:x: Finished component verification: **1 component(s) test failed** out of 1 component(s) tested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #8095: CAMEL-17947 + CAMEL-18327
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8095:
URL: https://github.com/apache/camel/pull/8095#issuecomment-1202352348
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org