You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2015/05/12 23:42:51 UTC
Review Request 34124: Removing dead code from StateManagerImpl.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34124/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Repository: aurora
Description
-------
Removing dead code from StateManagerImpl.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/state/SideEffect.java 180852e56734f5b03cf52bd8324db36612b33ade
src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 2a943cf51d0a41260ada6965cea5f55db4c3f846
src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java b30a0737bb0d60cd8b58f7be0fff5db20f808347
Diff: https://reviews.apache.org/r/34124/diff/
Testing
-------
Thanks,
Maxim Khutornenko
Re: Review Request 34124: Removing dead code from StateManagerImpl.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34124/#review83500
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On May 12, 2015, 9:42 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34124/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 9:42 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Removing dead code from StateManagerImpl.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/state/SideEffect.java 180852e56734f5b03cf52bd8324db36612b33ade
> src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 2a943cf51d0a41260ada6965cea5f55db4c3f846
> src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java b30a0737bb0d60cd8b58f7be0fff5db20f808347
>
> Diff: https://reviews.apache.org/r/34124/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 34124: Removing dead code from StateManagerImpl.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34124/#review83501
-----------------------------------------------------------
Ship it!
Master (759ef68) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 12, 2015, 9:42 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34124/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 9:42 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Removing dead code from StateManagerImpl.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/state/SideEffect.java 180852e56734f5b03cf52bd8324db36612b33ade
> src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 2a943cf51d0a41260ada6965cea5f55db4c3f846
> src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java b30a0737bb0d60cd8b58f7be0fff5db20f808347
>
> Diff: https://reviews.apache.org/r/34124/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>