You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/03 02:17:32 UTC
[GitHub] [beam] sfc-gh-kbregula opened a new pull request #17257: [BEAM-11936] Fix errorprone warnings and others in SnowflakeIO
sfc-gh-kbregula opened a new pull request #17257:
URL: https://github.com/apache/beam/pull/17257
Fixed warnings found by error checker or JetBrains IDE.
The least obvious might be the changes to the `SnowflakeService` interface, which has now become `SnowflakeService[s]`, but I had to do that because `SnowflakeService` was a generic class, which made it difficult to fix rawtypes warnings and made the code overly complicated.
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17257: [BEAM-11936] Fix errorprone warnings and others in SnowflakeIO
Posted by GitBox <gi...@apache.org>.
asf-ci commented on pull request #17257:
URL: https://github.com/apache/beam/pull/17257#issuecomment-1086761709
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sfc-gh-kbregula commented on a change in pull request #17257: [BEAM-11936] Fix errorprone warnings and others in SnowflakeIO
Posted by GitBox <gi...@apache.org>.
sfc-gh-kbregula commented on a change in pull request #17257:
URL: https://github.com/apache/beam/pull/17257#discussion_r841145961
##########
File path: sdks/java/io/snowflake/src/test/java/org/apache/beam/sdk/io/snowflake/test/unit/write/CreateDispositionTest.java
##########
@@ -48,22 +45,18 @@
import org.junit.runners.JUnit4;
@RunWith(JUnit4.class)
-@SuppressWarnings({
- "rawtypes", // TODO(https://issues.apache.org/jira/browse/BEAM-10556)
-})
public class CreateDispositionTest {
private static final String FAKE_TABLE = "FAKE_TABLE";
private static final String BUCKET_NAME = "bucket/";
@Rule public final transient TestPipeline pipeline = TestPipeline.create();
- @Rule public ExpectedException exceptionRule = ExpectedException.none();
Review comment:
`ExpectedException.none` is deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sfc-gh-kbregula commented on a change in pull request #17257: [BEAM-11936] Fix rawtypes warnings in SnowflakeIO
Posted by GitBox <gi...@apache.org>.
sfc-gh-kbregula commented on a change in pull request #17257:
URL: https://github.com/apache/beam/pull/17257#discussion_r841145961
##########
File path: sdks/java/io/snowflake/src/test/java/org/apache/beam/sdk/io/snowflake/test/unit/write/CreateDispositionTest.java
##########
@@ -48,22 +45,18 @@
import org.junit.runners.JUnit4;
@RunWith(JUnit4.class)
-@SuppressWarnings({
- "rawtypes", // TODO(https://issues.apache.org/jira/browse/BEAM-10556)
-})
public class CreateDispositionTest {
private static final String FAKE_TABLE = "FAKE_TABLE";
private static final String BUCKET_NAME = "bucket/";
@Rule public final transient TestPipeline pipeline = TestPipeline.create();
- @Rule public ExpectedException exceptionRule = ExpectedException.none();
Review comment:
`ExpectedException.none` is deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org