You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yuluo-yx (via GitHub)" <gi...@apache.org> on 2026/09/01 15:33:08 UTC
[I] DLQ resend actions can submit duplicate side effects [rocketmq-dashboard]
yuluo-yx opened a new issue, #2888:
URL: https://github.com/apache/rocketmq-dashboard/issues/2888
### Problem\n\nThe DLQ page uses retrySubmitting and detailResending React state as its only submission protection. Two confirmation events in the same render start two resendDLQ operations. The group resend dialog and selected-message resend action can also overlap, causing duplicate message delivery.\n\n### Reproduction\n\n1. Open a DLQ group and enter a target topic.\n2. Dispatch two Confirm Resend clicks before the first request resolves.\n3. Observe two resendDLQ calls with the same group, time range, and target topic.\n\nA focused DLQ page test reproduces the duplicate side effect using a deferred promise.\n\n### Expected behavior\n\nUse a synchronous page-level resend guard shared by group and selected-message resend operations.\n\n### Scope\n\nThe DLQ page resend lifecycle and its focused component test only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] DLQ resend actions can submit duplicate side effects [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed issue #2888: DLQ resend actions can submit duplicate side effects
URL: https://github.com/apache/rocketmq-dashboard/issues/2888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] DLQ resend actions can submit duplicate side effects [rocketmq-dashboard]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #2888:
URL: https://github.com/apache/rocketmq-dashboard/issues/2888#issuecomment-5500452491
**Issue Evaluation**
Category: `bug` | Status: **Confirmed**
This is a valid race condition bug. The DLQ resend page relies on React state for submission guarding, allowing duplicate resend API calls when the user triggers the action multiple times before React commits the state update.
**Root Cause:** Same pattern as #2889, #2890, and #2891 — React state updates are asynchronous. The resend action can be dispatched multiple times before the loading guard takes effect.
**Impact:** Duplicate message resend calls to the backend; potential duplicate message delivery if the endpoint is not idempotent.
**Severity:** Medium-High — duplicate message delivery in DLQ resend has direct data integrity implications.
**Suggested fix:** Use a synchronous in-flight guard (`useRef` Set of pending resend IDs) checked synchronously before dispatching the API call. Clear on completion or error.
An automated fix proposal can be generated. Reply `/approve` to proceed with PR generation.
---
*Automated evaluation by github-manager*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] DLQ resend actions can submit duplicate side effects [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on issue #2888:
URL: https://github.com/apache/rocketmq-dashboard/issues/2888#issuecomment-5536507023
Resolved by #2893 (merged into rocketmq-studio as 531b2be0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org