You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Purshotam Shah <pu...@yahoo-inc.com> on 2014/07/15 10:11:47 UTC
Review Request 23472: OOZIE-1915 Move system properties to conf properties
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23472/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-1915
https://issues.apache.org/jira/browse/OOZIE-1915
Repository: oozie-git
Description
-------
Move system properties to conf properties
Diffs
-----
core/src/main/java/org/apache/oozie/service/ConfigurationService.java 798782e
core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java 128347e
core/src/main/java/org/apache/oozie/util/ConfigUtils.java cdf6b48
core/src/main/java/org/apache/oozie/util/ZKUtils.java 74f6266
core/src/main/resources/oozie-default.xml b38801f
docs/src/site/twiki/AG_Install.twiki 8b0d110
Diff: https://reviews.apache.org/r/23472/diff/
Testing
-------
Thanks,
Purshotam Shah
Re: Review Request 23472: OOZIE-1915 Move system properties to conf
properties
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
> On July 15, 2014, 7:45 p.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java, line 267
> > <https://reviews.apache.org/r/23472/diff/2/?file=632169#file632169line267>
> >
> > Can you fix oozie base url in SLAEmailEventListener also?
SLAEmailEventListener uses joburl and it should point to oozie.base.url, not oozie.http.hostname.
oozie.base.url will point to vip url, where oozie.http.hostname will point to individual host.
joburl should always go through VIP.
> On July 15, 2014, 7:45 p.m., Rohini Palaniswamy wrote:
> > docs/src/site/twiki/AG_Install.twiki, line 801
> > <https://reviews.apache.org/r/23472/diff/2/?file=632173#file632173line801>
> >
> > Change the value of =OOZIE_BASE_URL= in oozie-env.sh or oozie-site.xml to point to the loadbalancer or virtual IP. The environmental variable takes precedence over the value in oozie-site.xml. For example:
> >
> > ....
> >
> > Keep both the examples (export and oozie-site.xml setting) with an (or) in between
For simplicity we should encourage people to use only oozie-site/oozie-default configuration.
We are supporting oozie-env.sh for backward compatibility.
> On July 15, 2014, 7:45 p.m., Rohini Palaniswamy wrote:
> > docs/src/site/twiki/AG_Install.twiki, line 811
> > <https://reviews.apache.org/r/23472/diff/2/?file=632173#file632173line811>
> >
> > can also be configured as oozie.instance.id in oozie-site.xml. The environmental variable takes precedence over oozie-site.xml.
For simplicity we should encourage people to use only oozie-site/oozie-default configuration.
We are supporting oozie-env.sh for backward compatibility.
Made modification to doc, removed oozie-env.sh configuration.
- Purshotam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23472/#review47801
-----------------------------------------------------------
On July 15, 2014, 8:11 a.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23472/
> -----------------------------------------------------------
>
> (Updated July 15, 2014, 8:11 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1915
> https://issues.apache.org/jira/browse/OOZIE-1915
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Move system properties to conf properties
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/service/ConfigurationService.java 798782e
> core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java 128347e
> core/src/main/java/org/apache/oozie/util/ConfigUtils.java cdf6b48
> core/src/main/java/org/apache/oozie/util/ZKUtils.java 74f6266
> core/src/main/resources/oozie-default.xml b38801f
> docs/src/site/twiki/AG_Install.twiki 8b0d110
>
> Diff: https://reviews.apache.org/r/23472/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 23472: OOZIE-1915 Move system properties to conf
properties
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23472/#review47801
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/service/ConfigurationService.java
<https://reviews.apache.org/r/23472/#comment84016>
Overriding configuration with system property
core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java
<https://reviews.apache.org/r/23472/#comment84017>
Can you fix oozie base url in SLAEmailEventListener also?
core/src/main/java/org/apache/oozie/util/ZKUtils.java
<https://reviews.apache.org/r/23472/#comment84018>
Did you mean to get value of oozie.http.hostname as default instead of just "oozie.http.hostname" ?
docs/src/site/twiki/AG_Install.twiki
<https://reviews.apache.org/r/23472/#comment84020>
Change the value of =OOZIE_BASE_URL= in oozie-env.sh or oozie-site.xml to point to the loadbalancer or virtual IP. The environmental variable takes precedence over the value in oozie-site.xml. For example:
....
Keep both the examples (export and oozie-site.xml setting) with an (or) in between
docs/src/site/twiki/AG_Install.twiki
<https://reviews.apache.org/r/23472/#comment84022>
can also be configured as oozie.instance.id in oozie-site.xml. The environmental variable takes precedence over oozie-site.xml.
- Rohini Palaniswamy
On July 15, 2014, 8:11 a.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23472/
> -----------------------------------------------------------
>
> (Updated July 15, 2014, 8:11 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1915
> https://issues.apache.org/jira/browse/OOZIE-1915
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Move system properties to conf properties
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/service/ConfigurationService.java 798782e
> core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java 128347e
> core/src/main/java/org/apache/oozie/util/ConfigUtils.java cdf6b48
> core/src/main/java/org/apache/oozie/util/ZKUtils.java 74f6266
> core/src/main/resources/oozie-default.xml b38801f
> docs/src/site/twiki/AG_Install.twiki 8b0d110
>
> Diff: https://reviews.apache.org/r/23472/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 23472: OOZIE-1915 Move system properties to conf
properties
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23472/#review47825
-----------------------------------------------------------
Ship it!
Ship It!
- Rohini Palaniswamy
On July 15, 2014, 9:44 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23472/
> -----------------------------------------------------------
>
> (Updated July 15, 2014, 9:44 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1915
> https://issues.apache.org/jira/browse/OOZIE-1915
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Move system properties to conf properties
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/service/ConfigurationService.java 798782e
> core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java 128347e
> core/src/main/java/org/apache/oozie/util/ConfigUtils.java cdf6b48
> core/src/main/java/org/apache/oozie/util/ZKUtils.java 74f6266
> core/src/main/resources/oozie-default.xml b38801f
> docs/src/site/twiki/AG_Install.twiki 8b0d110
>
> Diff: https://reviews.apache.org/r/23472/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 23472: OOZIE-1915 Move system properties to conf
properties
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23472/
-----------------------------------------------------------
(Updated July 15, 2014, 9:44 p.m.)
Review request for oozie.
Bugs: OOZIE-1915
https://issues.apache.org/jira/browse/OOZIE-1915
Repository: oozie-git
Description
-------
Move system properties to conf properties
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/service/ConfigurationService.java 798782e
core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java 128347e
core/src/main/java/org/apache/oozie/util/ConfigUtils.java cdf6b48
core/src/main/java/org/apache/oozie/util/ZKUtils.java 74f6266
core/src/main/resources/oozie-default.xml b38801f
docs/src/site/twiki/AG_Install.twiki 8b0d110
Diff: https://reviews.apache.org/r/23472/diff/
Testing
-------
Thanks,
Purshotam Shah