You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@maven.apache.org by GitBox <gi...@apache.org> on 2021/05/02 17:38:03 UTC

[GitHub] [maven-artifact-transfer] cstamas commented on pull request #24: [MSHARED-987] Make use of SISU

cstamas commented on pull request #24:
URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830844133


   General remark @michael-o : I did not made any other code change then:
   * added to methods ProjectBuildingRequest
   * removed reflection bits, replaced with direct calls
   * removed some reflection utilities, replaced with direct calls
   
   My point is, that those NPE comments of your are about _old code_, I did not introduce any logic/code change in that area, and IMO we can do those later as improvement, but for now I'd leave code as is (is really just "reshuffled" into modules + changes I wrote above).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org