You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "mstefany (via GitHub)" <gi...@apache.org> on 2024/01/10 09:26:46 UTC

[PR] feat: support PDB in apisix-ingress-controller [apisix-helm-chart]

mstefany opened a new pull request, #695:
URL: https://github.com/apache/apisix-helm-chart/pull/695

   Apisix Helm Chart [allows](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/templates/pdb.yaml) to define `PodDisruptionBudget` policy, but this Helm Chart for `apisix-ingress-controller` does not. This PR adds supports for it.
   The code is basically a copy of `PodDisruptionBudget` [template](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/templates/pdb.yaml) from mentioned chart, while first if statement is inspired by template of `ingress-nginx` controller's `PodDisruptionBudget` template, if that's OK.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: support PDB in apisix-ingress-controller [apisix-helm-chart]

Posted by "AlinsRan (via GitHub)" <gi...@apache.org>.
AlinsRan merged PR #695:
URL: https://github.com/apache/apisix-helm-chart/pull/695


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: support PDB in apisix-ingress-controller [apisix-helm-chart]

Posted by "zll600 (via GitHub)" <gi...@apache.org>.
zll600 commented on PR #695:
URL: https://github.com/apache/apisix-helm-chart/pull/695#issuecomment-1906250223

   @AlinsRan Could you help reivew this pr?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org