You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Mikhail Bautin (Created) (JIRA)" <ji...@apache.org> on 2011/12/14 23:01:32 UTC

[jira] [Created] (HBASE-5031) [89-fb] Remove hard-coded non-existent host name from TestScanner

[89-fb] Remove hard-coded non-existent host name from TestScanner 
------------------------------------------------------------------

                 Key: HBASE-5031
                 URL: https://issues.apache.org/jira/browse/HBASE-5031
             Project: HBase
          Issue Type: Bug
            Reporter: Mikhail Bautin
            Priority: Minor


TestScanner is failing on 0.89-fb because it has a hard-coded fake host name that it is trying to look up. Replacing this with 127.0.0.1:<random_port> instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5031) [89-fb] Remove hard-coded non-existent host name from TestScanner

Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phabricator updated HBASE-5031:
-------------------------------

    Attachment: D867.1.patch

mbautin requested code review of "[jira] [HBASE-5031] Remove hard-coded non-existent host name from TestScanner".
Reviewers: Liyin, Kannan, JIRA

  TestScanner is failing on 0.89-fb because it has a hard-coded fake host name that it is trying to look up. Replacing this with 127.0.0.1:<random_port> instead.

TEST PLAN
  Run TestScanner

REVISION DETAIL
  https://reviews.facebook.net/D867

AFFECTED FILES
  src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
  src/test/java/org/apache/hadoop/hbase/regionserver/TestScanner.java

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/1839/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.

                
> [89-fb] Remove hard-coded non-existent host name from TestScanner 
> ------------------------------------------------------------------
>
>                 Key: HBASE-5031
>                 URL: https://issues.apache.org/jira/browse/HBASE-5031
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Mikhail Bautin
>            Priority: Minor
>         Attachments: D867.1.patch
>
>
> TestScanner is failing on 0.89-fb because it has a hard-coded fake host name that it is trying to look up. Replacing this with 127.0.0.1:<random_port> instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5031) [89-fb] Remove hard-coded non-existent host name from TestScanner

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169798#comment-13169798 ] 

Phabricator commented on HBASE-5031:
------------------------------------

Liyin has commented on the revision "[jira] [HBASE-5031] [89-fb] Remove hard-coded non-existent host name from TestScanner".

  Nice work. Thanks Mikhail for fixing this unit test.

REVISION DETAIL
  https://reviews.facebook.net/D867

                
> [89-fb] Remove hard-coded non-existent host name from TestScanner 
> ------------------------------------------------------------------
>
>                 Key: HBASE-5031
>                 URL: https://issues.apache.org/jira/browse/HBASE-5031
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Mikhail Bautin
>            Priority: Minor
>         Attachments: D867.1.patch
>
>
> TestScanner is failing on 0.89-fb because it has a hard-coded fake host name that it is trying to look up. Replacing this with 127.0.0.1:<random_port> instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5031) [89-fb] Remove hard-coded non-existent host name from TestScanner

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208883#comment-13208883 ] 

Phabricator commented on HBASE-5031:
------------------------------------

mbautin has abandoned the revision "[jira] [HBASE-5031] [89-fb] Remove hard-coded non-existent host name from TestScanner".

  Committed internally, closing the diff.

REVISION DETAIL
  https://reviews.facebook.net/D867

                
> [89-fb] Remove hard-coded non-existent host name from TestScanner 
> ------------------------------------------------------------------
>
>                 Key: HBASE-5031
>                 URL: https://issues.apache.org/jira/browse/HBASE-5031
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Mikhail Bautin
>            Priority: Minor
>         Attachments: D867.1.patch
>
>
> TestScanner is failing on 0.89-fb because it has a hard-coded fake host name that it is trying to look up. Replacing this with 127.0.0.1:<random_port> instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5031) [89-fb] Remove hard-coded non-existent host name from TestScanner

Posted by "Nicolas Spiegelberg (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176782#comment-13176782 ] 

Nicolas Spiegelberg commented on HBASE-5031:
--------------------------------------------

@Mikhail: is this pertinent to trunk or only 89-fb?  This is the current stopping point in my linear merge.
                
> [89-fb] Remove hard-coded non-existent host name from TestScanner 
> ------------------------------------------------------------------
>
>                 Key: HBASE-5031
>                 URL: https://issues.apache.org/jira/browse/HBASE-5031
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Mikhail Bautin
>            Priority: Minor
>         Attachments: D867.1.patch
>
>
> TestScanner is failing on 0.89-fb because it has a hard-coded fake host name that it is trying to look up. Replacing this with 127.0.0.1:<random_port> instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5031) [89-fb] Remove hard-coded non-existent host name from TestScanner

Posted by "Mikhail Bautin (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176787#comment-13176787 ] 

Mikhail Bautin commented on HBASE-5031:
---------------------------------------

@Nicolas: TestScanner was only failing for this reason in 89-fb. Looking at the trunk version, I see that it does not use HServerAddress (which is deprecated in trunk) and does not perform a hostname lookup on "bar.foo.com". So yes, this is only relevant to 89-fb.
                
> [89-fb] Remove hard-coded non-existent host name from TestScanner 
> ------------------------------------------------------------------
>
>                 Key: HBASE-5031
>                 URL: https://issues.apache.org/jira/browse/HBASE-5031
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Mikhail Bautin
>            Priority: Minor
>         Attachments: D867.1.patch
>
>
> TestScanner is failing on 0.89-fb because it has a hard-coded fake host name that it is trying to look up. Replacing this with 127.0.0.1:<random_port> instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5031) [89-fb] Remove hard-coded non-existent host name from TestScanner

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169797#comment-13169797 ] 

Phabricator commented on HBASE-5031:
------------------------------------

Liyin has accepted the revision "[jira] [HBASE-5031] [89-fb] Remove hard-coded non-existent host name from TestScanner".

REVISION DETAIL
  https://reviews.facebook.net/D867

                
> [89-fb] Remove hard-coded non-existent host name from TestScanner 
> ------------------------------------------------------------------
>
>                 Key: HBASE-5031
>                 URL: https://issues.apache.org/jira/browse/HBASE-5031
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Mikhail Bautin
>            Priority: Minor
>         Attachments: D867.1.patch
>
>
> TestScanner is failing on 0.89-fb because it has a hard-coded fake host name that it is trying to look up. Replacing this with 127.0.0.1:<random_port> instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (HBASE-5031) [89-fb] Remove hard-coded non-existent host name from TestScanner

Posted by "Nicolas Spiegelberg (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Spiegelberg resolved HBASE-5031.
----------------------------------------

      Resolution: Fixed
    Release Note: Fixed in 0.89-fb.  Not necessary in trunk
    
> [89-fb] Remove hard-coded non-existent host name from TestScanner 
> ------------------------------------------------------------------
>
>                 Key: HBASE-5031
>                 URL: https://issues.apache.org/jira/browse/HBASE-5031
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Mikhail Bautin
>            Priority: Minor
>         Attachments: D867.1.patch
>
>
> TestScanner is failing on 0.89-fb because it has a hard-coded fake host name that it is trying to look up. Replacing this with 127.0.0.1:<random_port> instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira