You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/11/29 15:01:03 UTC
[GitHub] [skywalking-banyandb] hanahmily opened a new pull request, #223: Fix issues found through onboarding the showcase env
hanahmily opened a new pull request, #223:
URL: https://github.com/apache/skywalking-banyandb/pull/223
These changes contain issues found by integrating the showcase workloads and the BanyanDB server.
## API
- Add a field to the interval writing message for debugging.
## Bugs:
- Correct the overlapping of blocks/segments
- Correct block start time
- Correct the docID of the inverted index
## Enhancement:
- Add more debug info
- Refactor logs
- Update block and segment prefix templates
- Add series literal to debug info
- Compute log output only if the debug log is enabled
## Chores
- Bump up OAP
Signed-off-by: Gao Hongtao <ha...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] codecov-commenter commented on pull request #223: Fix issues found through onboarding the showcase env
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #223:
URL: https://github.com/apache/skywalking-banyandb/pull/223#issuecomment-1330854109
# [Codecov](https://codecov.io/gh/apache/skywalking-banyandb/pull/223?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#223](https://codecov.io/gh/apache/skywalking-banyandb/pull/223?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8243166) into [main](https://codecov.io/gh/apache/skywalking-banyandb/commit/10b82961d89ec7a4b0e593ef22561c3ceb281731?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (10b8296) will **decrease** coverage by `0.65%`.
> The diff coverage is `34.68%`.
```diff
@@ Coverage Diff @@
## main #223 +/- ##
==========================================
- Coverage 43.87% 43.22% -0.66%
==========================================
Files 87 87
Lines 8704 8949 +245
==========================================
+ Hits 3819 3868 +49
- Misses 4539 4709 +170
- Partials 346 372 +26
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking-banyandb/pull/223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [banyand/liaison/grpc/discovery.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC9saWFpc29uL2dycGMvZGlzY292ZXJ5Lmdv) | `10.52% <0.00%> (-0.59%)` | :arrow_down: |
| [banyand/liaison/grpc/measure.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC9saWFpc29uL2dycGMvbWVhc3VyZS5nbw==) | `0.00% <0.00%> (ø)` | |
| [banyand/liaison/grpc/stream.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC9saWFpc29uL2dycGMvc3RyZWFtLmdv) | `0.00% <0.00%> (ø)` | |
| [banyand/measure/measure\_query.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC9tZWFzdXJlL21lYXN1cmVfcXVlcnkuZ28=) | `0.00% <0.00%> (ø)` | |
| [banyand/measure/measure\_topn.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC9tZWFzdXJlL21lYXN1cmVfdG9wbi5nbw==) | `23.55% <0.00%> (-0.23%)` | :arrow_down: |
| [banyand/measure/measure\_write.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC9tZWFzdXJlL21lYXN1cmVfd3JpdGUuZ28=) | `4.06% <0.00%> (-0.18%)` | :arrow_down: |
| [banyand/measure/metadata.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC9tZWFzdXJlL21ldGFkYXRhLmdv) | `57.98% <ø> (ø)` | |
| [banyand/stream/metadata.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC9zdHJlYW0vbWV0YWRhdGEuZ28=) | `53.54% <ø> (ø)` | |
| [banyand/stream/stream\_write.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC9zdHJlYW0vc3RyZWFtX3dyaXRlLmdv) | `13.88% <0.00%> (-0.40%)` | :arrow_down: |
| [banyand/tsdb/bucket/bucket.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC90c2RiL2J1Y2tldC9idWNrZXQuZ28=) | `0.00% <0.00%> (ø)` | |
| ... and [32 more](https://codecov.io/gh/apache/skywalking-banyandb/pull/223/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] wu-sheng merged pull request #223: Fix issues found through onboarding the showcase env
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #223:
URL: https://github.com/apache/skywalking-banyandb/pull/223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org