You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by bu...@apache.org on 2017/11/14 05:23:19 UTC
[3/6] hbase git commit: HBASE-19249 test for "hbase antipatterns"
should check _count_ of occurance rather than text of
HBASE-19249 test for "hbase antipatterns" should check _count_ of occurance rather than text of
Signed-off-by: Apekshit Sharma <ap...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/ade166d5
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/ade166d5
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/ade166d5
Branch: refs/heads/branch-1.4
Commit: ade166d5f80be1a6f57a36b9fc4a8ecee6e40d4d
Parents: 626d74f
Author: Sean Busbey <bu...@apache.org>
Authored: Mon Nov 13 16:12:32 2017 -0600
Committer: Sean Busbey <bu...@apache.org>
Committed: Mon Nov 13 23:18:37 2017 -0600
----------------------------------------------------------------------
dev-support/hbase-personality.sh | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/ade166d5/dev-support/hbase-personality.sh
----------------------------------------------------------------------
diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh
index f70c51b..f9bc7e8 100755
--- a/dev-support/hbase-personality.sh
+++ b/dev-support/hbase-personality.sh
@@ -431,15 +431,15 @@ function hbaseanti_patchfile
start_clock
- warnings=$(${GREP} 'new TreeMap<byte.*()' "${patchfile}")
+ warnings=$(${GREP} -c 'new TreeMap<byte.*()' "${patchfile}")
if [[ ${warnings} -gt 0 ]]; then
- add_vote_table -1 hbaseanti "" "The patch appears to have anti-pattern where BYTES_COMPARATOR was omitted: ${warnings}."
+ add_vote_table -1 hbaseanti "" "The patch appears to have anti-pattern where BYTES_COMPARATOR was omitted."
((result=result+1))
fi
- warnings=$(${GREP} 'import org.apache.hadoop.classification' "${patchfile}")
+ warnings=$(${GREP} -c 'import org.apache.hadoop.classification' "${patchfile}")
if [[ ${warnings} -gt 0 ]]; then
- add_vote_table -1 hbaseanti "" "The patch appears use Hadoop classification instead of HBase: ${warnings}."
+ add_vote_table -1 hbaseanti "" "The patch appears use Hadoop classification instead of HBase."
((result=result+1))
fi