You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by d2r <gi...@git.apache.org> on 2018/10/02 15:55:30 UTC
[GitHub] storm pull request #2858: STORM-3242: Adds "examples" and "externals" profil...
GitHub user d2r opened a pull request:
https://github.com/apache/storm/pull/2858
STORM-3242: Adds "examples" and "externals" profiles
The existing modules have been moved into like-named Maven profiles that
are enabled by default.
They can be disabled, for example, with:
```
mvn clean install -DskipTests=true -P '!examples,!externals'
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/d2r/storm storm-3242-examples-externals-maven-profiles
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2858.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2858
----
commit be8c224b3fcc4ab15b3b10674432289dd5676260
Author: Derek Dagit <de...@...>
Date: 2018-10-02T15:54:04Z
Adds "examples" and "externals" profiles
The existing modules have been moved into like-named Maven profiles that
are enabled by default.
They can be disabled, for example, with:
```
mvn clean install -DskipTests=true -P '!examples,!externals'
```
----
---
[GitHub] storm pull request #2858: STORM-3242: Adds "examples" and "externals" profil...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2858
---
[GitHub] storm issue #2858: STORM-3242: Adds "examples" and "externals" profiles
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2858
Thanks @d2r, merged to master.
---
[GitHub] storm issue #2858: STORM-3242: Adds "examples" and "externals" profiles
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2858
+1, thanks for addressing my comment. Please squash to one commit containing the issue number.
---
[GitHub] storm issue #2858: STORM-3242: Adds "examples" and "externals" profiles
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the issue:
https://github.com/apache/storm/pull/2858
Agree. If there are errors/failures in travis-ci, then I will take a look.
---
[GitHub] storm issue #2858: STORM-3242: Adds "examples" and "externals" profiles
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2858
I'd be fine with just moving them to the new profile. It already contains the integration test, which also isn't in externals.
---
[GitHub] storm issue #2858: STORM-3242: Adds "examples" and "externals" profiles
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the issue:
https://github.com/apache/storm/pull/2858
Squashed; old commit was 9aeac5e517d6f5b1a7c1aba0afc0385a99144471.
---
[GitHub] storm issue #2858: STORM-3242: Adds "examples" and "externals" profiles
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2858
Sorry @srdo is right we need to make sure that we have the dependencies setup properly.
---
[GitHub] storm issue #2858: STORM-3242: Adds "examples" and "externals" profiles
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the issue:
https://github.com/apache/storm/pull/2858
Yes, thank you @srdo for pointing this out.
Would it be all right merely to move `flux` and `sql` to the new `externals` profile, or would we need make source code/layout changes as well to keep things organized?
---
[GitHub] storm issue #2858: STORM-3242: Adds "examples" and "externals" profiles
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the issue:
https://github.com/apache/storm/pull/2858
OK this is done.
Tested using:
```Bash
rm -rf ~/.m2/repository/
mvn clean install -DskipTests=true -U -P '!examples,!externals'
```
---
[GitHub] storm issue #2858: STORM-3242: Adds "examples" and "externals" profiles
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2858
This looks good, but I'm wondering if Flux and the sql modules should be added to externals as well? They depend on storm-kafka-client, so the build won't work with externals disabled unless you happen to already have storm-kafka-client in your local repo.
---