You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/13 14:57:21 UTC
[GitHub] [flink] GJL commented on a change in pull request #10541:
[FLINK-15169][runtime] Set failures happen in DefaultScheduler to
ExecutionGraph/Execution to make them visible to REST
GJL commented on a change in pull request #10541: [FLINK-15169][runtime] Set failures happen in DefaultScheduler to ExecutionGraph/Execution to make them visible to REST
URL: https://github.com/apache/flink/pull/10541#discussion_r357683696
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultExecutionVertexOperations.java
##########
@@ -35,4 +35,9 @@ public void deploy(final ExecutionVertex executionVertex) throws JobException {
public CompletableFuture<?> cancel(final ExecutionVertex executionVertex) {
return executionVertex.cancel();
}
+
+ @Override
+ public void markFailed(final ExecutionVertex executionVertex, final Throwable cause) {
+ executionVertex.markFailed(cause);
Review comment:
Solution looks correct. What is not so nice is that the meaning of the `fromSchedulerNg` is hard(er) to understand.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services