You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by HyukjinKwon <gi...@git.apache.org> on 2016/12/15 03:22:17 UTC
[GitHub] zeppelin pull request #1763: [MINOR] Add trivial cosmetic changes on STYLE.m...
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/zeppelin/pull/1763
[MINOR] Add trivial cosmetic changes on STYLE.md
### What is this PR for?
This PR proposes a little bit of cosmetic changes on `STYLE.md`.
**Before**
```
"src-noconflict/mode-sql.js",
"src-noconflict/mode-markdown.js",
"src-noconflict/keybinding-emacs.js",
"src-noconflict/ext-language_tools.js",
+ "src-noconflict/theme-github.js"],
"version": "1.1.8",
"name": "ace-builds"
},
"highlightjs": {
"main": ["highlight.pack.js",
+ "styles/github.css"],
"version": "8.4.0",
"name": "highlightjs"
}
```
```
- $scope.editor.setTheme('ace/theme/github');
+ $scope.editor.setTheme('ace/theme/monokai');
```
```
- "src-noconflict/theme-github.js"],
+ "src-noconflict/theme-monokai.js"],
```
**After**
```diff
"src-noconflict/mode-sql.js",
"src-noconflict/mode-markdown.js",
"src-noconflict/keybinding-emacs.js",
"src-noconflict/ext-language_tools.js",
+ "src-noconflict/theme-github.js"],
"version": "1.1.8",
"name": "ace-builds"
},
"highlightjs": {
"main": ["highlight.pack.js",
+ "styles/github.css"],
"version": "8.4.0",
"name": "highlightjs"
}
```
```diff
- $scope.editor.setTheme('ace/theme/github');
+ $scope.editor.setTheme('ace/theme/monokai');
```
```diff
- "src-noconflict/theme-github.js"],
+ "src-noconflict/theme-monokai.js"],
```
### What type of PR is it?
[Documentation]
### What is the Jira issue?
MINOR
### How should this be tested?
Manually checked the rendering
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/zeppelin minor-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1763.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1763
----
commit a6fcbd31baa92c726a54e7b917f54903160396bf
Author: hyukjinkwon <gu...@gmail.com>
Date: 2016-12-15T02:44:24Z
Add trivial cosmetic changes on STYLE.md
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1763: [MINOR] Add trivial cosmetic changes on STYLE.md
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/zeppelin/pull/1763
Hi @felixcheung, it seems the last change was by you. Could you please take a look? I think I am not used to this and also not sure if this change is good or not but just decided to submit this as it just looks a little bit prettier apparently.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1763: [MINOR] Add trivial cosmetic changes on STYLE.md
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1763
@HyukjinKwon Thanks for your contribution. Looks nice \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1763: [MINOR] Add trivial cosmetic changes on STYLE.md
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1763
merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1763: [MINOR] Add trivial cosmetic changes on STYLE.m...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon closed the pull request at:
https://github.com/apache/zeppelin/pull/1763
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1763: [MINOR] Add trivial cosmetic changes on STYLE.m...
Posted by HyukjinKwon <gi...@git.apache.org>.
GitHub user HyukjinKwon reopened a pull request:
https://github.com/apache/zeppelin/pull/1763
[MINOR] Add trivial cosmetic changes on STYLE.md
### What is this PR for?
This PR proposes a little bit of cosmetic changes on `STYLE.md`.
**Before**
```
"src-noconflict/mode-sql.js",
"src-noconflict/mode-markdown.js",
"src-noconflict/keybinding-emacs.js",
"src-noconflict/ext-language_tools.js",
+ "src-noconflict/theme-github.js"],
"version": "1.1.8",
"name": "ace-builds"
},
"highlightjs": {
"main": ["highlight.pack.js",
+ "styles/github.css"],
"version": "8.4.0",
"name": "highlightjs"
}
```
```
- $scope.editor.setTheme('ace/theme/github');
+ $scope.editor.setTheme('ace/theme/monokai');
```
```
- "src-noconflict/theme-github.js"],
+ "src-noconflict/theme-monokai.js"],
```
**After**
```diff
"src-noconflict/mode-sql.js",
"src-noconflict/mode-markdown.js",
"src-noconflict/keybinding-emacs.js",
"src-noconflict/ext-language_tools.js",
+ "src-noconflict/theme-github.js"],
"version": "1.1.8",
"name": "ace-builds"
},
"highlightjs": {
"main": ["highlight.pack.js",
+ "styles/github.css"],
"version": "8.4.0",
"name": "highlightjs"
}
```
```diff
- $scope.editor.setTheme('ace/theme/github');
+ $scope.editor.setTheme('ace/theme/monokai');
```
```diff
- "src-noconflict/theme-github.js"],
+ "src-noconflict/theme-monokai.js"],
```
### What type of PR is it?
[Documentation]
### What is the Jira issue?
MINOR
### How should this be tested?
Manually checked the rendering
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/zeppelin minor-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1763.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1763
----
commit a6fcbd31baa92c726a54e7b917f54903160396bf
Author: hyukjinkwon <gu...@gmail.com>
Date: 2016-12-15T02:44:24Z
Add trivial cosmetic changes on STYLE.md
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1763: [MINOR] Add trivial cosmetic changes on STYLE.md
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1763
CI failure is not related, since this is a .md that is not part of the doc build
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1763: [MINOR] Add trivial cosmetic changes on STYLE.md
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1763
nice!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1763: [MINOR] Add trivial cosmetic changes on STYLE.md
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/zeppelin/pull/1763
Thank you, @AhyoungRyu.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1763: [MINOR] Add trivial cosmetic changes on STYLE.md
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/zeppelin/pull/1763
Thanks @fellixcheng, would I maybe have to retrigger the build for the green?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1763: [MINOR] Add trivial cosmetic changes on STYLE.m...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1763
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1763: [MINOR] Add trivial cosmetic changes on STYLE.m...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon closed the pull request at:
https://github.com/apache/zeppelin/pull/1763
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1763: [MINOR] Add trivial cosmetic changes on STYLE.m...
Posted by HyukjinKwon <gi...@git.apache.org>.
GitHub user HyukjinKwon reopened a pull request:
https://github.com/apache/zeppelin/pull/1763
[MINOR] Add trivial cosmetic changes on STYLE.md
### What is this PR for?
This PR proposes a little bit of cosmetic changes on `STYLE.md`.
**Before**
```
"src-noconflict/mode-sql.js",
"src-noconflict/mode-markdown.js",
"src-noconflict/keybinding-emacs.js",
"src-noconflict/ext-language_tools.js",
+ "src-noconflict/theme-github.js"],
"version": "1.1.8",
"name": "ace-builds"
},
"highlightjs": {
"main": ["highlight.pack.js",
+ "styles/github.css"],
"version": "8.4.0",
"name": "highlightjs"
}
```
```
- $scope.editor.setTheme('ace/theme/github');
+ $scope.editor.setTheme('ace/theme/monokai');
```
```
- "src-noconflict/theme-github.js"],
+ "src-noconflict/theme-monokai.js"],
```
**After**
```diff
"src-noconflict/mode-sql.js",
"src-noconflict/mode-markdown.js",
"src-noconflict/keybinding-emacs.js",
"src-noconflict/ext-language_tools.js",
+ "src-noconflict/theme-github.js"],
"version": "1.1.8",
"name": "ace-builds"
},
"highlightjs": {
"main": ["highlight.pack.js",
+ "styles/github.css"],
"version": "8.4.0",
"name": "highlightjs"
}
```
```diff
- $scope.editor.setTheme('ace/theme/github');
+ $scope.editor.setTheme('ace/theme/monokai');
```
```diff
- "src-noconflict/theme-github.js"],
+ "src-noconflict/theme-monokai.js"],
```
### What type of PR is it?
[Documentation]
### What is the Jira issue?
MINOR
### How should this be tested?
Manually checked the rendering
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/zeppelin minor-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1763.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1763
----
commit a6fcbd31baa92c726a54e7b917f54903160396bf
Author: hyukjinkwon <gu...@gmail.com>
Date: 2016-12-15T02:44:24Z
Add trivial cosmetic changes on STYLE.md
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---