You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Benedikt Ritter <be...@gmail.com> on 2015/06/02 08:27:42 UTC
Re: RandomStringUtils with variable lengths
Hello Caleb,
2015-05-24 22:16 GMT+02:00 Caleb Cushing <xe...@gmail.com>:
> I have written the following for my own project, and a couple of
> variants elsewhere (randomNumeric( min, max ) etc.
>
> Also I'm considering maybe a randomGraph() (for printable characters
> that match the posix graph regex), and random utf8.
>
> I find these useful for test input data.
>
> if I wrote it into a patch for RandomStringUtils including docs and
> tests would it be accepted/is it something the project would be
> interested in? (please cc me I'm not on the list)
>
> public class RandomUtil {
> public static String randomAlphanumeric( final int minLength,
> final int maxLength ) {
> return RandomStringUtils.randomAlphanumeric(
> RandomUtils.nextInt( minLength, maxLength ) );
> }
> }
>
I'm not sure I understand your proposal. Is this about returning a single
random character?
It would be good if you could provide a patch with some unit tests. You can
use GitHub for contributing [1]
Thank you!
Benedikt
[1] https://github.com/apache/commons-lang
>
>
> --
> Caleb Cushing
>
> http://xenoterracide.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: RandomStringUtils with variable lengths
Posted by Caleb Cushing <xe...@gmail.com>.
https://github.com/apache/commons-lang/pull/101 created a new pull request
after doing some branch rewrites.
On Mon, Jun 22, 2015 at 1:02 PM Benedikt Ritter <br...@apache.org> wrote:
> Yes, please go ahead!
>
>
> 2015-06-20 2:44 GMT+02:00 Caleb Cushing <xe...@gmail.com>:
>
>> so should I spend the time working this into a more finalized patch, that
>> includes the stuff for numeric and alphanumeric as well? (and fixes the
>> feedback)
>>
>> On Sun, Jun 7, 2015 at 6:23 AM Benedikt Ritter <br...@apache.org>
>> wrote:
>>
>>> Hello Caleb,
>>>
>>> 2015-06-06 21:45 GMT+02:00 Caleb Cushing <xe...@gmail.com>:
>>>
>>>>
>>>>> I'm not sure I understand your proposal. Is this about returning a
>>>>> single random character?
>>>>> It would be good if you could provide a patch with some unit tests.
>>>>> You can use GitHub for contributing [1]
>>>>>
>>>>
>>>> I created a preliminary pull request here
>>>>
>>>> https://github.com/apache/commons-lang/pull/94
>>>>
>>>> (side note: I'm perplexed how I could have affected the test that's
>>>> failing on Java 8)
>>>>
>>>
>>> Thank you, I'll have a look soon.
>>>
>>>
>>>> --
>>>> Caleb Cushing
>>>>
>>>
>>>
>>>
>>> --
>>> http://people.apache.org/~britter/
>>> http://www.systemoutprintln.de/
>>> http://twitter.com/BenediktRitter
>>> http://github.com/britter
>>>
>> --
>> Caleb Cushing
>>
>> http://xenoterracide.com
>>
>
>
>
> --
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter
>
--
Caleb Cushing
http://xenoterracide.com
Re: RandomStringUtils with variable lengths
Posted by Benedikt Ritter <br...@apache.org>.
Yes, please go ahead!
2015-06-20 2:44 GMT+02:00 Caleb Cushing <xe...@gmail.com>:
> so should I spend the time working this into a more finalized patch, that
> includes the stuff for numeric and alphanumeric as well? (and fixes the
> feedback)
>
> On Sun, Jun 7, 2015 at 6:23 AM Benedikt Ritter <br...@apache.org> wrote:
>
>> Hello Caleb,
>>
>> 2015-06-06 21:45 GMT+02:00 Caleb Cushing <xe...@gmail.com>:
>>
>>>
>>>> I'm not sure I understand your proposal. Is this about returning a
>>>> single random character?
>>>> It would be good if you could provide a patch with some unit tests. You
>>>> can use GitHub for contributing [1]
>>>>
>>>
>>> I created a preliminary pull request here
>>>
>>> https://github.com/apache/commons-lang/pull/94
>>>
>>> (side note: I'm perplexed how I could have affected the test that's
>>> failing on Java 8)
>>>
>>
>> Thank you, I'll have a look soon.
>>
>>
>>> --
>>> Caleb Cushing
>>>
>>
>>
>>
>> --
>> http://people.apache.org/~britter/
>> http://www.systemoutprintln.de/
>> http://twitter.com/BenediktRitter
>> http://github.com/britter
>>
> --
> Caleb Cushing
>
> http://xenoterracide.com
>
--
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter
Re: RandomStringUtils with variable lengths
Posted by Caleb Cushing <xe...@gmail.com>.
so should I spend the time working this into a more finalized patch, that
includes the stuff for numeric and alphanumeric as well? (and fixes the
feedback)
On Sun, Jun 7, 2015 at 6:23 AM Benedikt Ritter <br...@apache.org> wrote:
> Hello Caleb,
>
> 2015-06-06 21:45 GMT+02:00 Caleb Cushing <xe...@gmail.com>:
>
>>
>>> I'm not sure I understand your proposal. Is this about returning a
>>> single random character?
>>> It would be good if you could provide a patch with some unit tests. You
>>> can use GitHub for contributing [1]
>>>
>>
>> I created a preliminary pull request here
>>
>> https://github.com/apache/commons-lang/pull/94
>>
>> (side note: I'm perplexed how I could have affected the test that's
>> failing on Java 8)
>>
>
> Thank you, I'll have a look soon.
>
>
>> --
>> Caleb Cushing
>>
>
>
>
> --
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter
>
--
Caleb Cushing
http://xenoterracide.com
Re: RandomStringUtils with variable lengths
Posted by Benedikt Ritter <br...@apache.org>.
Hello Caleb,
2015-06-06 21:45 GMT+02:00 Caleb Cushing <xe...@gmail.com>:
>
>> I'm not sure I understand your proposal. Is this about returning a single
>> random character?
>> It would be good if you could provide a patch with some unit tests. You
>> can use GitHub for contributing [1]
>>
>
> I created a preliminary pull request here
>
> https://github.com/apache/commons-lang/pull/94
>
> (side note: I'm perplexed how I could have affected the test that's
> failing on Java 8)
>
Thank you, I'll have a look soon.
> --
> Caleb Cushing
>
--
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter
Re: RandomStringUtils with variable lengths
Posted by Caleb Cushing <xe...@gmail.com>.
>
>
> I'm not sure I understand your proposal. Is this about returning a single
> random character?
> It would be good if you could provide a patch with some unit tests. You
> can use GitHub for contributing [1]
>
I created a preliminary pull request here
https://github.com/apache/commons-lang/pull/94
(side note: I'm perplexed how I could have affected the test that's failing
on Java 8)
--
Caleb Cushing