You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Tim Sell (JIRA)" <ji...@apache.org> on 2009/01/20 23:28:59 UTC
[jira] Created: (HBASE-1142) Cleanup thrift server
Cleanup thrift server
---------------------
Key: HBASE-1142
URL: https://issues.apache.org/jira/browse/HBASE-1142
Project: Hadoop HBase
Issue Type: Bug
Affects Versions: 0.18.1, 0.18.0, 0.19.0, 0.19.1
Reporter: Tim Sell
Fix For: 0.19.1
Ambiguous issue name.. sorry.
The thrift server has loads of getText(..) calls. Which is a local function that checks for utf8 compliance, we don't need them anywhere, because we don't use Text anymore.
There is probably other things we missed last time we updated the api, that we should also clean up while we're at it. Open to suggestions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1142) Cleanup thrift server; remove Text and
profuse DEBUG messaging
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-1142:
-------------------------
Fix Version/s: (was: 0.20.0)
0.19.1
Moving to 0.19.1 (I'll commit it there in a while). Tim describes it as a bug (its already marked as a Bug).
> Cleanup thrift server; remove Text and profuse DEBUG messaging
> --------------------------------------------------------------
>
> Key: HBASE-1142
> URL: https://issues.apache.org/jira/browse/HBASE-1142
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0, 0.18.1, 0.19.0, 0.19.1
> Reporter: Tim Sell
> Assignee: Tim Sell
> Priority: Minor
> Fix For: 0.19.1
>
> Attachments: HBASE-1142.patch
>
>
> Ambiguous issue name.. sorry.
> The thrift server has loads of getText(..) calls. Which is a local function that checks for utf8 compliance, we don't need them anywhere, because we don't use Text anymore.
> There is probably other things we missed last time we updated the api, that we should also clean up while we're at it. Open to suggestions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1142) Cleanup thrift server; remove Text
and profuse DEBUG messaging
Posted by "Billy Pearson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667019#action_12667019 ]
Billy Pearson commented on HBASE-1142:
--------------------------------------
Question can mutateRows update more then one row or is it to update more then one column for a single row in one call?
> Cleanup thrift server; remove Text and profuse DEBUG messaging
> --------------------------------------------------------------
>
> Key: HBASE-1142
> URL: https://issues.apache.org/jira/browse/HBASE-1142
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0, 0.18.1, 0.19.0, 0.19.1
> Reporter: Tim Sell
> Assignee: Tim Sell
> Priority: Minor
> Fix For: 0.19.1
>
> Attachments: HBASE-1142.patch
>
>
> Ambiguous issue name.. sorry.
> The thrift server has loads of getText(..) calls. Which is a local function that checks for utf8 compliance, we don't need them anywhere, because we don't use Text anymore.
> There is probably other things we missed last time we updated the api, that we should also clean up while we're at it. Open to suggestions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1142) Cleanup thrift server; remove Text and
profuse DEBUG messaging
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-1142:
-------------------------
Summary: Cleanup thrift server; remove Text and profuse DEBUG messaging (was: Cleanup thrift server)
> Cleanup thrift server; remove Text and profuse DEBUG messaging
> --------------------------------------------------------------
>
> Key: HBASE-1142
> URL: https://issues.apache.org/jira/browse/HBASE-1142
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0, 0.18.1, 0.19.0, 0.19.1
> Reporter: Tim Sell
> Priority: Minor
> Fix For: 0.19.1
>
> Attachments: HBASE-1142.patch
>
>
> Ambiguous issue name.. sorry.
> The thrift server has loads of getText(..) calls. Which is a local function that checks for utf8 compliance, we don't need them anywhere, because we don't use Text anymore.
> There is probably other things we missed last time we updated the api, that we should also clean up while we're at it. Open to suggestions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-1142) Cleanup thrift server; remove Text
and profuse DEBUG messaging
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-1142.
--------------------------
Resolution: Fixed
Committed to branch. Thanks for the patch Tim.
> Cleanup thrift server; remove Text and profuse DEBUG messaging
> --------------------------------------------------------------
>
> Key: HBASE-1142
> URL: https://issues.apache.org/jira/browse/HBASE-1142
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0, 0.18.1, 0.19.0, 0.19.1
> Reporter: Tim Sell
> Assignee: Tim Sell
> Priority: Minor
> Fix For: 0.19.1
>
> Attachments: HBASE-1142.patch
>
>
> Ambiguous issue name.. sorry.
> The thrift server has loads of getText(..) calls. Which is a local function that checks for utf8 compliance, we don't need them anywhere, because we don't use Text anymore.
> There is probably other things we missed last time we updated the api, that we should also clean up while we're at it. Open to suggestions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1142) Cleanup thrift server; remove Text
and profuse DEBUG messaging
Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666142#action_12666142 ]
Tim Sell commented on HBASE-1142:
---------------------------------
It doesn't change the api at all, so 19.1 makes sense. As it stands it enforces utf8 content row keys, definitely a bug.
> Cleanup thrift server; remove Text and profuse DEBUG messaging
> --------------------------------------------------------------
>
> Key: HBASE-1142
> URL: https://issues.apache.org/jira/browse/HBASE-1142
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0, 0.18.1, 0.19.0, 0.19.1
> Reporter: Tim Sell
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HBASE-1142.patch
>
>
> Ambiguous issue name.. sorry.
> The thrift server has loads of getText(..) calls. Which is a local function that checks for utf8 compliance, we don't need them anywhere, because we don't use Text anymore.
> There is probably other things we missed last time we updated the api, that we should also clean up while we're at it. Open to suggestions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-1142) Cleanup thrift server; remove Text
and profuse DEBUG messaging
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-1142.
--------------------------
Resolution: Fixed
Fix Version/s: (was: 0.19.1)
0.20.0
Committed. Thanks for the patch Tim.
We should consider whether to add this to 0.19.1?
> Cleanup thrift server; remove Text and profuse DEBUG messaging
> --------------------------------------------------------------
>
> Key: HBASE-1142
> URL: https://issues.apache.org/jira/browse/HBASE-1142
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0, 0.18.1, 0.19.0, 0.19.1
> Reporter: Tim Sell
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HBASE-1142.patch
>
>
> Ambiguous issue name.. sorry.
> The thrift server has loads of getText(..) calls. Which is a local function that checks for utf8 compliance, we don't need them anywhere, because we don't use Text anymore.
> There is probably other things we missed last time we updated the api, that we should also clean up while we're at it. Open to suggestions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1142) Cleanup thrift server; remove Text
and profuse DEBUG messaging
Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666328#action_12666328 ]
Tim Sell commented on HBASE-1142:
---------------------------------
Billy: mutateRows and mutateRowsTs both take a list of BatchMutations.
The Ts version lets you provide a timestamp. We need separate functions because thrift doesn't allow method overloading.
Maybe I'll might have a quick look at the python democlient on the weekend. Feel free to work on any of them :)
That's a separate issue.
> Cleanup thrift server; remove Text and profuse DEBUG messaging
> --------------------------------------------------------------
>
> Key: HBASE-1142
> URL: https://issues.apache.org/jira/browse/HBASE-1142
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0, 0.18.1, 0.19.0, 0.19.1
> Reporter: Tim Sell
> Assignee: Tim Sell
> Priority: Minor
> Fix For: 0.19.1
>
> Attachments: HBASE-1142.patch
>
>
> Ambiguous issue name.. sorry.
> The thrift server has loads of getText(..) calls. Which is a local function that checks for utf8 compliance, we don't need them anywhere, because we don't use Text anymore.
> There is probably other things we missed last time we updated the api, that we should also clean up while we're at it. Open to suggestions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1142) Cleanup thrift server
Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Sell updated HBASE-1142:
----------------------------
Priority: Minor (was: Major)
> Cleanup thrift server
> ---------------------
>
> Key: HBASE-1142
> URL: https://issues.apache.org/jira/browse/HBASE-1142
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0, 0.18.1, 0.19.0, 0.19.1
> Reporter: Tim Sell
> Priority: Minor
> Fix For: 0.19.1
>
> Attachments: HBASE-1142.patch
>
>
> Ambiguous issue name.. sorry.
> The thrift server has loads of getText(..) calls. Which is a local function that checks for utf8 compliance, we don't need them anywhere, because we don't use Text anymore.
> There is probably other things we missed last time we updated the api, that we should also clean up while we're at it. Open to suggestions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (HBASE-1142) Cleanup thrift server; remove Text
and profuse DEBUG messaging
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack reopened HBASE-1142:
--------------------------
Assignee: Tim Sell
> Cleanup thrift server; remove Text and profuse DEBUG messaging
> --------------------------------------------------------------
>
> Key: HBASE-1142
> URL: https://issues.apache.org/jira/browse/HBASE-1142
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0, 0.18.1, 0.19.0, 0.19.1
> Reporter: Tim Sell
> Assignee: Tim Sell
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HBASE-1142.patch
>
>
> Ambiguous issue name.. sorry.
> The thrift server has loads of getText(..) calls. Which is a local function that checks for utf8 compliance, we don't need them anywhere, because we don't use Text anymore.
> There is probably other things we missed last time we updated the api, that we should also clean up while we're at it. Open to suggestions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1142) Cleanup thrift server
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666005#action_12666005 ]
stack commented on HBASE-1142:
------------------------------
Thanks Tim. Patch looks great. Let me commit...
> Cleanup thrift server
> ---------------------
>
> Key: HBASE-1142
> URL: https://issues.apache.org/jira/browse/HBASE-1142
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0, 0.18.1, 0.19.0, 0.19.1
> Reporter: Tim Sell
> Priority: Minor
> Fix For: 0.19.1
>
> Attachments: HBASE-1142.patch
>
>
> Ambiguous issue name.. sorry.
> The thrift server has loads of getText(..) calls. Which is a local function that checks for utf8 compliance, we don't need them anywhere, because we don't use Text anymore.
> There is probably other things we missed last time we updated the api, that we should also clean up while we're at it. Open to suggestions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1142) Cleanup thrift server; remove Text
and profuse DEBUG messaging
Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667026#action_12667026 ]
Tim Sell commented on HBASE-1142:
---------------------------------
I made another jira (HBASE-1153) to update the python example for that. mutateRow is for changes over multiple columns of one row. mutateRows is for changes of multiple columns over multiple rows.
> Cleanup thrift server; remove Text and profuse DEBUG messaging
> --------------------------------------------------------------
>
> Key: HBASE-1142
> URL: https://issues.apache.org/jira/browse/HBASE-1142
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0, 0.18.1, 0.19.0, 0.19.1
> Reporter: Tim Sell
> Assignee: Tim Sell
> Priority: Minor
> Fix For: 0.19.1
>
> Attachments: HBASE-1142.patch
>
>
> Ambiguous issue name.. sorry.
> The thrift server has loads of getText(..) calls. Which is a local function that checks for utf8 compliance, we don't need them anywhere, because we don't use Text anymore.
> There is probably other things we missed last time we updated the api, that we should also clean up while we're at it. Open to suggestions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1142) Cleanup thrift server
Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Sell updated HBASE-1142:
----------------------------
Attachment: HBASE-1142.patch
This also fixes HBASE-889 (you can just pass it an empty list of columns to scan all).
> Cleanup thrift server
> ---------------------
>
> Key: HBASE-1142
> URL: https://issues.apache.org/jira/browse/HBASE-1142
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0, 0.18.1, 0.19.0, 0.19.1
> Reporter: Tim Sell
> Fix For: 0.19.1
>
> Attachments: HBASE-1142.patch
>
>
> Ambiguous issue name.. sorry.
> The thrift server has loads of getText(..) calls. Which is a local function that checks for utf8 compliance, we don't need them anywhere, because we don't use Text anymore.
> There is probably other things we missed last time we updated the api, that we should also clean up while we're at it. Open to suggestions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1142) Cleanup thrift server; remove Text
and profuse DEBUG messaging
Posted by "Billy Pearson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666275#action_12666275 ]
Billy Pearson commented on HBASE-1142:
--------------------------------------
Tim: Can we get some updates to the demo clients also there is a function in ThriftServer mutateRows and mutateRowsTS, I assume there there to do batch updates to multi rows in one call but can not find an example on how to setup rowBatches.
> Cleanup thrift server; remove Text and profuse DEBUG messaging
> --------------------------------------------------------------
>
> Key: HBASE-1142
> URL: https://issues.apache.org/jira/browse/HBASE-1142
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0, 0.18.1, 0.19.0, 0.19.1
> Reporter: Tim Sell
> Assignee: Tim Sell
> Priority: Minor
> Fix For: 0.19.1
>
> Attachments: HBASE-1142.patch
>
>
> Ambiguous issue name.. sorry.
> The thrift server has loads of getText(..) calls. Which is a local function that checks for utf8 compliance, we don't need them anywhere, because we don't use Text anymore.
> There is probably other things we missed last time we updated the api, that we should also clean up while we're at it. Open to suggestions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.