[jira] [Commented] (SENTRY-1505) CommitContext isn't used by anything and should be removed

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SENTRY-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15631638#comment-15631638 ] 

Hadoop QA commented on SENTRY-1505:
-----------------------------------

Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12836720/SENTRY-1505.2.patch against master.

{color:green}Overall:{color} +1 all checks pass

{color:green}SUCCESS:{color} all tests passed

Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/2124/console

This message is automatically generated.

> CommitContext isn't used by anything and should be removed
> ----------------------------------------------------------
>
>                 Key: SENTRY-1505
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1505
>             Project: Sentry
>          Issue Type: Improvement
>          Components: Sentry
>    Affects Versions: 1.7.0, sentry-ha-redesign
>            Reporter: Alexander Kolbasov
>            Assignee: Alexander Kolbasov
>            Priority: Minor
>         Attachments: SENTRY-1505.0.patch, SENTRY-1505.1.patch, SENTRY-1505.2.patch
>
>
> Sentry code defines class CommitContext which keeps track of sequence ID for transaction. It is passed around many places in the server code but isn't actually used by anything, so it is a dead code that should be trimmed. It just complicates things without any benefit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)