You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Jothi Padmanabhan (JIRA)" <ji...@apache.org> on 2009/04/13 06:40:15 UTC

[jira] Created: (HADOOP-5661) Resolve findbugs warnings in mapred

Resolve findbugs warnings in mapred
-----------------------------------

                 Key: HADOOP-5661
                 URL: https://issues.apache.org/jira/browse/HADOOP-5661
             Project: Hadoop Core
          Issue Type: Bug
          Components: mapred
            Reporter: Jothi Padmanabhan
            Assignee: Jothi Padmanabhan


Towards a solution for HADOOP-5628, we need to resolve all findbugs warnings. This jira will try to resolve the findbugs warnings where ever possible and suppress them where resolution is not possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5661) Resolve findbugs warnings in mapred

Posted by "Jothi Padmanabhan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700184#action_12700184 ] 

Jothi Padmanabhan commented on HADOOP-5661:
-------------------------------------------

ant test and test patch passed on my local box

> Resolve findbugs warnings in mapred
> -----------------------------------
>
>                 Key: HADOOP-5661
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5661
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Jothi Padmanabhan
>            Assignee: Jothi Padmanabhan
>         Attachments: hadoop-5661-v1.patch, hadoop-5661-v2.patch, hadoop-5661-v3.patch, hadoop-5661.patch
>
>
> Towards a solution for HADOOP-5628, we need to resolve all findbugs warnings. This jira will try to resolve the findbugs warnings where ever possible and suppress them where resolution is not possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5661) Resolve findbugs warnings in mapred

Posted by "Jothi Padmanabhan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jothi Padmanabhan updated HADOOP-5661:
--------------------------------------

    Status: Open  (was: Patch Available)

> Resolve findbugs warnings in mapred
> -----------------------------------
>
>                 Key: HADOOP-5661
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5661
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Jothi Padmanabhan
>            Assignee: Jothi Padmanabhan
>         Attachments: hadoop-5661-v1.patch, hadoop-5661-v2.patch, hadoop-5661-v3.patch, hadoop-5661.patch
>
>
> Towards a solution for HADOOP-5628, we need to resolve all findbugs warnings. This jira will try to resolve the findbugs warnings where ever possible and suppress them where resolution is not possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5661) Resolve findbugs warnings in mapred

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700725#action_12700725 ] 

Hudson commented on HADOOP-5661:
--------------------------------

Integrated in Hadoop-trunk #811 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/811/])
    . Fixes some findbugs warnings in o.a.h.mapred* packages and supresses a bunch of them. Contributed by Jothi Padmanabhan.


> Resolve findbugs warnings in mapred
> -----------------------------------
>
>                 Key: HADOOP-5661
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5661
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Jothi Padmanabhan
>            Assignee: Jothi Padmanabhan
>             Fix For: 0.21.0
>
>         Attachments: hadoop-5661-v1.patch, hadoop-5661-v2.patch, hadoop-5661-v3.patch, hadoop-5661.patch
>
>
> Towards a solution for HADOOP-5628, we need to resolve all findbugs warnings. This jira will try to resolve the findbugs warnings where ever possible and suppress them where resolution is not possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5661) Resolve findbugs warnings in mapred

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-5661:
--------------------------------

       Resolution: Fixed
    Fix Version/s: 0.21.0
     Hadoop Flags: [Reviewed]
           Status: Resolved  (was: Patch Available)

I just committed this. Thanks, Jothi!

> Resolve findbugs warnings in mapred
> -----------------------------------
>
>                 Key: HADOOP-5661
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5661
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Jothi Padmanabhan
>            Assignee: Jothi Padmanabhan
>             Fix For: 0.21.0
>
>         Attachments: hadoop-5661-v1.patch, hadoop-5661-v2.patch, hadoop-5661-v3.patch, hadoop-5661.patch
>
>
> Towards a solution for HADOOP-5628, we need to resolve all findbugs warnings. This jira will try to resolve the findbugs warnings where ever possible and suppress them where resolution is not possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5661) Resolve findbugs warnings in mapred

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700112#action_12700112 ] 

Amareshwari Sriramadasu commented on HADOOP-5661:
-------------------------------------------------

One comment:
Reducetask.ShuffleRamManager.getNumPendingRequests method need not be public.

> Resolve findbugs warnings in mapred
> -----------------------------------
>
>                 Key: HADOOP-5661
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5661
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Jothi Padmanabhan
>            Assignee: Jothi Padmanabhan
>         Attachments: hadoop-5661-v1.patch, hadoop-5661-v2.patch, hadoop-5661.patch
>
>
> Towards a solution for HADOOP-5628, we need to resolve all findbugs warnings. This jira will try to resolve the findbugs warnings where ever possible and suppress them where resolution is not possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5661) Resolve findbugs warnings in mapred

Posted by "Jothi Padmanabhan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jothi Padmanabhan updated HADOOP-5661:
--------------------------------------

    Attachment: hadoop-5661-v1.patch

The findbugs warnings reported for the previous patch did not show up in my local box where findbugs version is 1.3.8. We probably should upgrade the findbugs  for the automated testing system to 1.3.8 as well. In the interim, attaching a patch that should handle those two warnings.

The test failures with the previous patch are unrelated.

> Resolve findbugs warnings in mapred
> -----------------------------------
>
>                 Key: HADOOP-5661
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5661
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Jothi Padmanabhan
>            Assignee: Jothi Padmanabhan
>         Attachments: hadoop-5661-v1.patch, hadoop-5661.patch
>
>
> Towards a solution for HADOOP-5628, we need to resolve all findbugs warnings. This jira will try to resolve the findbugs warnings where ever possible and suppress them where resolution is not possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5661) Resolve findbugs warnings in mapred

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700358#action_12700358 ] 

Chris Douglas commented on HADOOP-5661:
---------------------------------------

{{TestFairScheduler}} no longer compiles:
{noformat}compile:
     [echo] contrib: fairscheduler

compile-examples:

compile-test:
     [echo] contrib: fairscheduler
    [javac] Compiling 1 source file to /snip/hadoop/build/contrib/fairscheduler/test
    [javac] /snip/hadoop/src/contrib/fairscheduler/src/test/org/apache/hadoop/mapred/TestFairScheduler.java:128: cannot find symbol
    [javac] symbol  : constructor ClusterStatus(int,int,int,int,int,org.apache.hadoop.mapred.JobTracker.State)
    [javac] location: class org.apache.hadoop.mapred.ClusterStatus
    [javac]       return new ClusterStatus(numTrackers, maps, reduces,
    [javac]              ^
    [javac] Note: /snip/hadoop/src/contrib/fairscheduler/src/test/org/apache/hadoop/mapred/TestFairScheduler.java uses or overrides a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] 1 error

BUILD FAILED
/snip/hadoop/build.xml:774: The following error occurred while executing this line:
/snip/hadoop/src/contrib/build.xml:48: The following error occurred while executing this line:
/snip/hadoop/src/contrib/build-contrib.xml:165: Compile failed; see the compiler error output for details.

Total time: 1 minute 2 seconds
{noformat}

> Resolve findbugs warnings in mapred
> -----------------------------------
>
>                 Key: HADOOP-5661
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5661
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Jothi Padmanabhan
>            Assignee: Jothi Padmanabhan
>             Fix For: 0.21.0
>
>         Attachments: hadoop-5661-v1.patch, hadoop-5661-v2.patch, hadoop-5661-v3.patch, hadoop-5661.patch
>
>
> Towards a solution for HADOOP-5628, we need to resolve all findbugs warnings. This jira will try to resolve the findbugs warnings where ever possible and suppress them where resolution is not possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5661) Resolve findbugs warnings in mapred

Posted by "Jothi Padmanabhan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jothi Padmanabhan updated HADOOP-5661:
--------------------------------------

    Status: Patch Available  (was: Open)

> Resolve findbugs warnings in mapred
> -----------------------------------
>
>                 Key: HADOOP-5661
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5661
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Jothi Padmanabhan
>            Assignee: Jothi Padmanabhan
>         Attachments: hadoop-5661-v1.patch, hadoop-5661-v2.patch, hadoop-5661.patch
>
>
> Towards a solution for HADOOP-5628, we need to resolve all findbugs warnings. This jira will try to resolve the findbugs warnings where ever possible and suppress them where resolution is not possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5661) Resolve findbugs warnings in mapred

Posted by "Jothi Padmanabhan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jothi Padmanabhan updated HADOOP-5661:
--------------------------------------

    Status: Patch Available  (was: Open)

ant test and test patch passed with this patch

> Resolve findbugs warnings in mapred
> -----------------------------------
>
>                 Key: HADOOP-5661
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5661
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Jothi Padmanabhan
>            Assignee: Jothi Padmanabhan
>         Attachments: hadoop-5661.patch
>
>
> Towards a solution for HADOOP-5628, we need to resolve all findbugs warnings. This jira will try to resolve the findbugs warnings where ever possible and suppress them where resolution is not possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5661) Resolve findbugs warnings in mapred

Posted by "Jothi Padmanabhan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jothi Padmanabhan updated HADOOP-5661:
--------------------------------------

    Status: Open  (was: Patch Available)

> Resolve findbugs warnings in mapred
> -----------------------------------
>
>                 Key: HADOOP-5661
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5661
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Jothi Padmanabhan
>            Assignee: Jothi Padmanabhan
>         Attachments: hadoop-5661-v1.patch, hadoop-5661.patch
>
>
> Towards a solution for HADOOP-5628, we need to resolve all findbugs warnings. This jira will try to resolve the findbugs warnings where ever possible and suppress them where resolution is not possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5661) Resolve findbugs warnings in mapred

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699522#action_12699522 ] 

Hadoop QA commented on HADOOP-5661:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12405391/hadoop-5661-v1.patch
  against trunk revision 765427.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 9 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/198/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/198/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/198/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/198/console

This message is automatically generated.

> Resolve findbugs warnings in mapred
> -----------------------------------
>
>                 Key: HADOOP-5661
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5661
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Jothi Padmanabhan
>            Assignee: Jothi Padmanabhan
>         Attachments: hadoop-5661-v1.patch, hadoop-5661.patch
>
>
> Towards a solution for HADOOP-5628, we need to resolve all findbugs warnings. This jira will try to resolve the findbugs warnings where ever possible and suppress them where resolution is not possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5661) Resolve findbugs warnings in mapred

Posted by "Jothi Padmanabhan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jothi Padmanabhan updated HADOOP-5661:
--------------------------------------

    Status: Patch Available  (was: Open)

> Resolve findbugs warnings in mapred
> -----------------------------------
>
>                 Key: HADOOP-5661
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5661
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Jothi Padmanabhan
>            Assignee: Jothi Padmanabhan
>         Attachments: hadoop-5661-v1.patch, hadoop-5661-v2.patch, hadoop-5661-v3.patch, hadoop-5661.patch
>
>
> Towards a solution for HADOOP-5628, we need to resolve all findbugs warnings. This jira will try to resolve the findbugs warnings where ever possible and suppress them where resolution is not possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5661) Resolve findbugs warnings in mapred

Posted by "Jothi Padmanabhan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jothi Padmanabhan updated HADOOP-5661:
--------------------------------------

    Attachment: hadoop-5661.patch

Patch fixing all mapred findbugs warnings

> Resolve findbugs warnings in mapred
> -----------------------------------
>
>                 Key: HADOOP-5661
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5661
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Jothi Padmanabhan
>            Assignee: Jothi Padmanabhan
>         Attachments: hadoop-5661.patch
>
>
> Towards a solution for HADOOP-5628, we need to resolve all findbugs warnings. This jira will try to resolve the findbugs warnings where ever possible and suppress them where resolution is not possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5661) Resolve findbugs warnings in mapred

Posted by "Jothi Padmanabhan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jothi Padmanabhan updated HADOOP-5661:
--------------------------------------

    Status: Patch Available  (was: Open)

> Resolve findbugs warnings in mapred
> -----------------------------------
>
>                 Key: HADOOP-5661
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5661
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Jothi Padmanabhan
>            Assignee: Jothi Padmanabhan
>         Attachments: hadoop-5661-v1.patch, hadoop-5661.patch
>
>
> Towards a solution for HADOOP-5628, we need to resolve all findbugs warnings. This jira will try to resolve the findbugs warnings where ever possible and suppress them where resolution is not possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5661) Resolve findbugs warnings in mapred

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700125#action_12700125 ] 

Amareshwari Sriramadasu commented on HADOOP-5661:
-------------------------------------------------

+1 changes look fine to me.

> Resolve findbugs warnings in mapred
> -----------------------------------
>
>                 Key: HADOOP-5661
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5661
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Jothi Padmanabhan
>            Assignee: Jothi Padmanabhan
>         Attachments: hadoop-5661-v1.patch, hadoop-5661-v2.patch, hadoop-5661-v3.patch, hadoop-5661.patch
>
>
> Towards a solution for HADOOP-5628, we need to resolve all findbugs warnings. This jira will try to resolve the findbugs warnings where ever possible and suppress them where resolution is not possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5661) Resolve findbugs warnings in mapred

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698485#action_12698485 ] 

Hadoop QA commented on HADOOP-5661:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12405319/hadoop-5661.patch
  against trunk revision 764287.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 9 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 2 new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/191/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/191/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/191/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/191/console

This message is automatically generated.

> Resolve findbugs warnings in mapred
> -----------------------------------
>
>                 Key: HADOOP-5661
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5661
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Jothi Padmanabhan
>            Assignee: Jothi Padmanabhan
>         Attachments: hadoop-5661.patch
>
>
> Towards a solution for HADOOP-5628, we need to resolve all findbugs warnings. This jira will try to resolve the findbugs warnings where ever possible and suppress them where resolution is not possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5661) Resolve findbugs warnings in mapred

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702763#action_12702763 ] 

Hudson commented on HADOOP-5661:
--------------------------------

Integrated in Hadoop-trunk #817 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/817/])
    HADOOP-5709. Remove redundant synchronization added in . Contributed by Jothi Padmanabhan.


> Resolve findbugs warnings in mapred
> -----------------------------------
>
>                 Key: HADOOP-5661
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5661
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Jothi Padmanabhan
>            Assignee: Jothi Padmanabhan
>             Fix For: 0.21.0
>
>         Attachments: hadoop-5661-v1.patch, hadoop-5661-v2.patch, hadoop-5661-v3.patch, hadoop-5661.patch
>
>
> Towards a solution for HADOOP-5628, we need to resolve all findbugs warnings. This jira will try to resolve the findbugs warnings where ever possible and suppress them where resolution is not possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5661) Resolve findbugs warnings in mapred

Posted by "Jothi Padmanabhan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jothi Padmanabhan updated HADOOP-5661:
--------------------------------------

    Status: Open  (was: Patch Available)

> Resolve findbugs warnings in mapred
> -----------------------------------
>
>                 Key: HADOOP-5661
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5661
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Jothi Padmanabhan
>            Assignee: Jothi Padmanabhan
>         Attachments: hadoop-5661-v1.patch, hadoop-5661-v2.patch, hadoop-5661.patch
>
>
> Towards a solution for HADOOP-5628, we need to resolve all findbugs warnings. This jira will try to resolve the findbugs warnings where ever possible and suppress them where resolution is not possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5661) Resolve findbugs warnings in mapred

Posted by "Jothi Padmanabhan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jothi Padmanabhan updated HADOOP-5661:
--------------------------------------

    Attachment: hadoop-5661-v2.patch

Synching patch with the latest trunk

> Resolve findbugs warnings in mapred
> -----------------------------------
>
>                 Key: HADOOP-5661
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5661
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Jothi Padmanabhan
>            Assignee: Jothi Padmanabhan
>         Attachments: hadoop-5661-v1.patch, hadoop-5661-v2.patch, hadoop-5661.patch
>
>
> Towards a solution for HADOOP-5628, we need to resolve all findbugs warnings. This jira will try to resolve the findbugs warnings where ever possible and suppress them where resolution is not possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5661) Resolve findbugs warnings in mapred

Posted by "Jothi Padmanabhan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jothi Padmanabhan updated HADOOP-5661:
--------------------------------------

    Attachment: hadoop-5661-v3.patch

Changed getNumPendingRequests() to be a private method

> Resolve findbugs warnings in mapred
> -----------------------------------
>
>                 Key: HADOOP-5661
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5661
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Jothi Padmanabhan
>            Assignee: Jothi Padmanabhan
>         Attachments: hadoop-5661-v1.patch, hadoop-5661-v2.patch, hadoop-5661-v3.patch, hadoop-5661.patch
>
>
> Towards a solution for HADOOP-5628, we need to resolve all findbugs warnings. This jira will try to resolve the findbugs warnings where ever possible and suppress them where resolution is not possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.