You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2021/04/20 13:15:24 UTC

[GitHub] [jena] afs opened a new pull request #987: JENA-2094: Run tests in strict environment

afs opened a new pull request #987:
URL: https://github.com/apache/jena/pull/987


   PR #986 fixed the problem reported but it broke some test that run in "strict" mode ("strict" mode validates the IRIProvider, not the way Jena uses it). 
   
   This PR runs the TS_IRIx tests in strict mode.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org


[GitHub] [jena] afs merged pull request #987: JENA-2094: Run tests in strict environment

Posted by GitBox <gi...@apache.org>.
afs merged pull request #987:
URL: https://github.com/apache/jena/pull/987


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org


[GitHub] [jena] kinow commented on a change in pull request #987: JENA-2094: Run tests in strict environment

Posted by GitBox <gi...@apache.org>.
kinow commented on a change in pull request #987:
URL: https://github.com/apache/jena/pull/987#discussion_r616994660



##########
File path: jena-core/src/test/java/org/apache/jena/irix/AbstractTestIRIx.java
##########
@@ -27,7 +27,10 @@
 import org.junit.BeforeClass;
 import org.junit.runners.Parameterized.Parameters;
 
-/** Test suite driver for IRIx */
+/** Test suite driver for IRIx.
+ * The test execution environment is set to be "strict".
+ * Tests can  change this; it is reset each test.

Review comment:
       missing "after" before each I think, but not important




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org