You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "KeDeng (Code Review)" <ge...@cloudera.org> on 2022/04/25 02:56:37 UTC
[kudu-CR] [unit test] Modify the return value of the test function 'CreateTable'.
KeDeng has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18445
Change subject: [unit test] Modify the return value of the test function 'CreateTable'.
......................................................................
[unit test] Modify the return value of the test function 'CreateTable'.
I'm going to submit a soft delete function. In relevant unit
tests, we need to judge the function results of 'CreateTable'.
Commit is mentioned separately here to implement this modification.
Change-Id: I114adce22a631b88de30943738a7356d4a451828
---
M src/kudu/client/client-test.cc
1 file changed, 28 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/18445/1
--
To view, visit http://gerrit.cloudera.org:8080/18445
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I114adce22a631b88de30943738a7356d4a451828
Gerrit-Change-Number: 18445
Gerrit-PatchSet: 1
Gerrit-Owner: KeDeng <kd...@gmail.com>
[kudu-CR] [unit test] Modify the return value of the test function 'CreateTable'.
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18445 )
Change subject: [unit test] Modify the return value of the test function 'CreateTable'.
......................................................................
Patch Set 2: Code-Review+2
Thanks a lot for separating this udpate!
--
To view, visit http://gerrit.cloudera.org:8080/18445
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I114adce22a631b88de30943738a7356d4a451828
Gerrit-Change-Number: 18445
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Mon, 25 Apr 2022 18:26:14 +0000
Gerrit-HasComments: No
[kudu-CR] [unit test] Modify the return value of the test function 'CreateTable'.
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18445 )
Change subject: [unit test] Modify the return value of the test function 'CreateTable'.
......................................................................
[unit test] Modify the return value of the test function 'CreateTable'.
I'm going to submit a soft delete function. In relevant unit
tests, we need to judge the function results of 'CreateTable'.
Commit is mentioned separately here to implement this modification.
Change-Id: I114adce22a631b88de30943738a7356d4a451828
Reviewed-on: http://gerrit.cloudera.org:8080/18445
Reviewed-by: Yingchun Lai <ac...@gmail.com>
Tested-by: Yingchun Lai <ac...@gmail.com>
---
M src/kudu/client/client-test.cc
1 file changed, 28 insertions(+), 28 deletions(-)
Approvals:
Yingchun Lai: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18445
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I114adce22a631b88de30943738a7356d4a451828
Gerrit-Change-Number: 18445
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [unit test] Modify the return value of the test function 'CreateTable'.
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.
Change subject: [unit test] Modify the return value of the test function 'CreateTable'.
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18445
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I114adce22a631b88de30943738a7356d4a451828
Gerrit-Change-Number: 18445
Gerrit-PatchSet: 1
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [unit test] Modify the return value of the test function 'CreateTable'.
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18445 )
Change subject: [unit test] Modify the return value of the test function 'CreateTable'.
......................................................................
Patch Set 1:
The failed tests are not related, I've removed it.
--
To view, visit http://gerrit.cloudera.org:8080/18445
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I114adce22a631b88de30943738a7356d4a451828
Gerrit-Change-Number: 18445
Gerrit-PatchSet: 1
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Mon, 25 Apr 2022 04:16:48 +0000
Gerrit-HasComments: No
[kudu-CR] [unit test] Modify the return value of the test function 'CreateTable'.
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18445 )
Change subject: [unit test] Modify the return value of the test function 'CreateTable'.
......................................................................
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18445
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I114adce22a631b88de30943738a7356d4a451828
Gerrit-Change-Number: 18445
Gerrit-PatchSet: 1
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Mon, 25 Apr 2022 04:17:04 +0000
Gerrit-HasComments: No