You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "o-nikolas (via GitHub)" <gi...@apache.org> on 2023/05/01 23:04:30 UTC

[GitHub] [airflow] o-nikolas commented on a diff in pull request #30727: Kubernetes Executor Load Time Optimizations

o-nikolas commented on code in PR #30727:
URL: https://github.com/apache/airflow/pull/30727#discussion_r1181954784


##########
airflow/executors/kubernetes_executor.py:
##########
@@ -621,6 +223,8 @@ def execute_async(
             self.log.info("Add task %s with command %s", key, command)
 
         try:
+            from airflow.kubernetes.pod_generator import PodGenerator

Review Comment:
   Sure, I tried to generally go with the philosophy of moving the imports as close to the usage as possible. Though, I can see/understand folks having lots of different personal preferences and pros/cons. Moving to the top of the method in this case is fine with me as long as we settle with that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org