[GitHub] [airflow] yourhiro commented on a change in pull request #5111: [AIRFLOW-4294] fix missing dag & task runs in UI when . in dag_id

[GitBox <gi...@apache.org>]

yourhiro commented on a change in pull request #5111: [AIRFLOW-4294] fix missing dag & task runs in UI when . in dag_id
URL: https://github.com/apache/airflow/pull/5111#discussion_r275950837
 
 

 ##########
 File path: airflow/www/templates/airflow/dags.html
 ##########
 @@ -312,7 +312,7 @@ <h2>DAGs</h2>
       d3.json("{{ url_for('Airflow.dag_stats') }}", function(error, json) {
         for(var dag_id in json) {
             states = json[dag_id];
-            g = d3.select('svg#dag-run-' + dag_id)
+            g = d3.select('svg#dag-run-' + dag_id.replace(/\./g, '__dot__'))
 
 Review comment:
   I considered doing that, but I felt it should be kept separate from the endpoint response since the conversion is only done for the sake of naming a DOM element. I don't think it'd be great to have the endpoint response keyed on a safe_dag_id rather than dag_id because that's unexpected.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services