You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/02/17 19:54:35 UTC
[GitHub] [accumulo-testing] milleruntime opened a new pull request #191: Make MulitTable reuse tables
milleruntime opened a new pull request #191:
URL: https://github.com/apache/accumulo-testing/pull/191
* This allows restarting rw tests and allow using of the same tables
across multiple threads
* Other various improvements to MultiTable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] DomGarguilo commented on a change in pull request #191: Make MulitTable reuse tables
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on a change in pull request #191:
URL: https://github.com/apache/accumulo-testing/pull/191#discussion_r809429311
##########
File path: src/main/java/org/apache/accumulo/testing/randomwalk/multitable/DropTable.java
##########
@@ -34,7 +34,7 @@ public void visit(State state, RandWalkEnv env, Properties props) throws Excepti
List<String> tables = (List<String>) state.get("tableList");
// don't drop a table if we only have one table or less
Review comment:
This comment might need to be updated to reflect the new if condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] milleruntime commented on a change in pull request #191: Make MulitTable reuse tables
Posted by GitBox <gi...@apache.org>.
milleruntime commented on a change in pull request #191:
URL: https://github.com/apache/accumulo-testing/pull/191#discussion_r809435563
##########
File path: src/main/java/org/apache/accumulo/testing/randomwalk/multitable/DropTable.java
##########
@@ -34,7 +34,7 @@ public void visit(State state, RandWalkEnv env, Properties props) throws Excepti
List<String> tables = (List<String>) state.get("tableList");
// don't drop a table if we only have one table or less
Review comment:
Fixed in bf9f3fc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] milleruntime commented on pull request #191: Make MulitTable reuse tables
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #191:
URL: https://github.com/apache/accumulo-testing/pull/191#issuecomment-1044721098
@DomGarguilo think this is OK to merge? I am going to use this for testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] milleruntime commented on a change in pull request #191: Make MulitTable reuse tables
Posted by GitBox <gi...@apache.org>.
milleruntime commented on a change in pull request #191:
URL: https://github.com/apache/accumulo-testing/pull/191#discussion_r809431202
##########
File path: src/main/java/org/apache/accumulo/testing/randomwalk/multitable/DropTable.java
##########
@@ -34,7 +34,7 @@ public void visit(State state, RandWalkEnv env, Properties props) throws Excepti
List<String> tables = (List<String>) state.get("tableList");
// don't drop a table if we only have one table or less
Review comment:
Ah yeah. I should probably make this configurable. Maybe as a follow on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] milleruntime merged pull request #191: Make MulitTable reuse tables
Posted by GitBox <gi...@apache.org>.
milleruntime merged pull request #191:
URL: https://github.com/apache/accumulo-testing/pull/191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org