You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/08 08:36:28 UTC
[GitHub] [spark] ulysses-you opened a new pull request #31521: [SPARK-34400][CORE] Check spark.job.interruptOnCancel value is illegal before submit job
ulysses-you opened a new pull request #31521:
URL: https://github.com/apache/spark/pull/31521
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Add value check before setLcoalProperty if key is `spark.job.interruptOnCancel`.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Checking config when setting is better than using.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
add test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31521: [SPARK-34400][CORE] Check spark.job.interruptOnCancel value is illegal before submit job
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31521:
URL: https://github.com/apache/spark/pull/31521#issuecomment-775071598
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31521: [SPARK-34400][CORE] Check spark.job.interruptOnCancel value is illegal before submit job
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31521:
URL: https://github.com/apache/spark/pull/31521#issuecomment-775049850
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39600/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #31521: [SPARK-34400][CORE] Check spark.job.interruptOnCancel value is illegal before submit job
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #31521:
URL: https://github.com/apache/spark/pull/31521#discussion_r572010794
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -719,10 +719,23 @@ class SparkContext(config: SparkConf) extends Logging {
if (value == null) {
localProperties.get.remove(key)
} else {
+ checkLocalProperty(key, value)
Review comment:
Do we expect users would set `spark.job.interruptOnCance` as I notice it's private? I think it may be better to prevent users from setting this kind of private property instead of doing check valid check. And we could recommend users to use `setJobGroup` instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31521: [SPARK-34400][CORE] Check spark.job.interruptOnCancel value is illegal before submit job
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31521:
URL: https://github.com/apache/spark/pull/31521#issuecomment-775069973
**[Test build #135017 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135017/testReport)** for PR 31521 at commit [`17669d9`](https://github.com/apache/spark/commit/17669d900568635be2151870101f0d6b33885230).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #31521: [SPARK-34400][CORE] Check spark.job.interruptOnCancel value is illegal before submit job
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #31521:
URL: https://github.com/apache/spark/pull/31521#discussion_r572010794
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -719,10 +719,23 @@ class SparkContext(config: SparkConf) extends Logging {
if (value == null) {
localProperties.get.remove(key)
} else {
+ checkLocalProperty(key, value)
Review comment:
Do we expect users would set `spark.job.interruptOnCance` as I notice it's private? I think it may be better to prevent users from setting this kind of private property instead of doing check valid check. And we could recommend users to use `setJobGroup` instead. cc @tgravescs @mridulm any thoughts about this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on a change in pull request #31521: [SPARK-34400][CORE] Check spark.job.interruptOnCancel value is illegal before submit job
Posted by GitBox <gi...@apache.org>.
tgravescs commented on a change in pull request #31521:
URL: https://github.com/apache/spark/pull/31521#discussion_r572101380
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -719,10 +719,23 @@ class SparkContext(config: SparkConf) extends Logging {
if (value == null) {
localProperties.get.remove(key)
} else {
+ checkLocalProperty(key, value)
Review comment:
oh sorry I guess we can't do that because local property
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31521: [SPARK-34400][CORE] Check spark.job.interruptOnCancel value is illegal before submit job
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31521:
URL: https://github.com/apache/spark/pull/31521#issuecomment-774999620
**[Test build #135017 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135017/testReport)** for PR 31521 at commit [`17669d9`](https://github.com/apache/spark/commit/17669d900568635be2151870101f0d6b33885230).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #31521: [SPARK-34400][CORE] Check spark.job.interruptOnCancel value is illegal before submit job
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #31521:
URL: https://github.com/apache/spark/pull/31521#issuecomment-775212358
thanks for the remind @tgravescs , has updated the description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #31521: [SPARK-34400][CORE] Check spark.job.interruptOnCancel value is illegal before submit job
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #31521:
URL: https://github.com/apache/spark/pull/31521#discussion_r572010794
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -719,10 +719,23 @@ class SparkContext(config: SparkConf) extends Logging {
if (value == null) {
localProperties.get.remove(key)
} else {
+ checkLocalProperty(key, value)
Review comment:
Do we expect users would set `spark.job.interruptOnCance` as I notice it's private? I think it may be better to prevent users from setting this kind of private property instead of doing the valid check. And we could recommend users to use `setJobGroup` instead. cc @tgravescs @mridulm any thoughts about this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31521: [SPARK-34400][CORE] Check spark.job.interruptOnCancel value is illegal before submit job
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31521:
URL: https://github.com/apache/spark/pull/31521#issuecomment-775032088
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39600/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #31521: [SPARK-34400][CORE] Check spark.job.interruptOnCancel value is illegal before submit job
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #31521:
URL: https://github.com/apache/spark/pull/31521#issuecomment-844581510
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on a change in pull request #31521: [SPARK-34400][CORE] Check spark.job.interruptOnCancel value is illegal before submit job
Posted by GitBox <gi...@apache.org>.
tgravescs commented on a change in pull request #31521:
URL: https://github.com/apache/spark/pull/31521#discussion_r572101380
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -719,10 +719,23 @@ class SparkContext(config: SparkConf) extends Logging {
if (value == null) {
localProperties.get.remove(key)
} else {
+ checkLocalProperty(key, value)
Review comment:
oh sorry I guess we can't do that because local property, I would like to more about context
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #31521: [SPARK-34400][CORE] Check spark.job.interruptOnCancel value is illegal before submit job
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #31521:
URL: https://github.com/apache/spark/pull/31521#discussion_r572010794
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -719,10 +719,23 @@ class SparkContext(config: SparkConf) extends Logging {
if (value == null) {
localProperties.get.remove(key)
} else {
+ checkLocalProperty(key, value)
Review comment:
Do we expect users would set `spark.job.interruptOnCance` (as I notice it's private)? I think it may be better to prevent users from setting this kind of private property instead of doing the valid check. And we could recommend users to use `setJobGroup` instead. cc @tgravescs @mridulm any thoughts about this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31521: [SPARK-34400][CORE] Check spark.job.interruptOnCancel value is illegal before submit job
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31521:
URL: https://github.com/apache/spark/pull/31521#issuecomment-774999620
**[Test build #135017 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135017/testReport)** for PR 31521 at commit [`17669d9`](https://github.com/apache/spark/commit/17669d900568635be2151870101f0d6b33885230).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #31521: [SPARK-34400][CORE] Check spark.job.interruptOnCancel value is illegal before submit job
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #31521:
URL: https://github.com/apache/spark/pull/31521#discussion_r572092112
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -719,10 +719,23 @@ class SparkContext(config: SparkConf) extends Logging {
if (value == null) {
localProperties.get.remove(key)
} else {
+ checkLocalProperty(key, value)
Review comment:
Yeah, we need the internal method if we want to forbid. May let's see others' feedback first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on pull request #31521: [SPARK-34400][CORE] Check spark.job.interruptOnCancel value is illegal before submit job
Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #31521:
URL: https://github.com/apache/spark/pull/31521#issuecomment-775196737
Can we get a better description? Why/How did this even come up? I assume some user just set it or was this for test case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #31521: [SPARK-34400][CORE] Check spark.job.interruptOnCancel value is illegal before submit job
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #31521:
URL: https://github.com/apache/spark/pull/31521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on a change in pull request #31521: [SPARK-34400][CORE] Check spark.job.interruptOnCancel value is illegal before submit job
Posted by GitBox <gi...@apache.org>.
tgravescs commented on a change in pull request #31521:
URL: https://github.com/apache/spark/pull/31521#discussion_r572100081
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -719,10 +719,23 @@ class SparkContext(config: SparkConf) extends Logging {
if (value == null) {
localProperties.get.remove(key)
} else {
+ checkLocalProperty(key, value)
Review comment:
we should just change this to use the ConfigBuilder. mark it as internal and the toBoolean function already does this same check to make sure valid. That doesn't prevent them from doing it though so if we wanted to add other checking for all internal that might be a bit more work and complex as I'm sure we use some for testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on a change in pull request #31521: [SPARK-34400][CORE] Check spark.job.interruptOnCancel value is illegal before submit job
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #31521:
URL: https://github.com/apache/spark/pull/31521#discussion_r572089450
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -719,10 +719,23 @@ class SparkContext(config: SparkConf) extends Logging {
if (value == null) {
localProperties.get.remove(key)
} else {
+ checkLocalProperty(key, value)
Review comment:
I perfer to the suggestion, forbid is better. If so we might need an another internal method to set local property for some test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31521: [SPARK-34400][CORE] Check spark.job.interruptOnCancel value is illegal before submit job
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31521:
URL: https://github.com/apache/spark/pull/31521#issuecomment-775071605
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on pull request #31521: [SPARK-34400][CORE] Check spark.job.interruptOnCancel value is illegal before submit job
Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #31521:
URL: https://github.com/apache/spark/pull/31521#issuecomment-775270808
so I guess user was trying to get this in real job.
like was said above its an internal config so if user gets it wrong I don't know that I care because they shouldn't be in the first place. they should use the official api.
I'm not sure its worth us checking every internal config to make sure user doesn't set it. I'm for just closing this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org