You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "tledkov (via GitHub)" <gi...@apache.org> on 2023/01/24 15:15:27 UTC

[GitHub] [ignite] tledkov commented on a diff in pull request #10494: IGNITE-18616 control.sh metric configuration added

tledkov commented on code in PR #10494:
URL: https://github.com/apache/ignite/pull/10494#discussion_r1085472041


##########
modules/control-utility/src/test/java/org/apache/ignite/util/MetricCommandTest.java:
##########
@@ -114,6 +117,88 @@ public void testNonExistentMetric() {
             "No metric with specified name was found [name=nonexistent.metric]");
     }
 
+    /** Tests command error output in case of invalid arguments for configure command. */
+    @Test
+    public void testInvalidConfigureMetricParameter() {

Review Comment:
   Please add the a check both config arguments: hitrate & bounds



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org