You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/17 12:11:46 UTC
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16022: [refactor](remove non vec) remove column block and column view
github-actions[bot] commented on code in PR #16022:
URL: https://github.com/apache/doris/pull/16022#discussion_r1072131340
##########
be/src/olap/rowset/segment_v2/page_decoder.h:
##########
@@ -72,16 +71,6 @@
return step;
}
- // Fetch the next vector of values from the page into 'column_vector_view'.
- // The output vector must have space for up to n cells.
- //
- // Return the size of read entries .
- //
- // In the case that the values are themselves references
- // to other memory (eg Slices), the referred-to memory is
- // allocated in the column_vector_view's mem_pool.
- virtual Status next_batch(size_t* n, ColumnBlockView* dst) = 0;
-
virtual Status next_batch(size_t* n, vectorized::MutableColumnPtr& dst) = 0;
virtual Status read_by_rowids(const rowid_t* rowids, ordinal_t page_first_ordinal, size_t* n,
Review Comment:
warning: unknown type name 'ordinal_t' [clang-diagnostic-error]
```cpp
virtual Status read_by_rowids(const rowid_t* rowids, ordinal_t page_first_ordinal, size_t* n,
^
```
##########
be/src/olap/rowset/segment_v2/page_decoder.h:
##########
@@ -72,16 +71,6 @@ class PageDecoder {
return step;
}
- // Fetch the next vector of values from the page into 'column_vector_view'.
- // The output vector must have space for up to n cells.
- //
- // Return the size of read entries .
- //
- // In the case that the values are themselves references
- // to other memory (eg Slices), the referred-to memory is
- // allocated in the column_vector_view's mem_pool.
- virtual Status next_batch(size_t* n, ColumnBlockView* dst) = 0;
-
virtual Status next_batch(size_t* n, vectorized::MutableColumnPtr& dst) = 0;
virtual Status read_by_rowids(const rowid_t* rowids, ordinal_t page_first_ordinal, size_t* n,
Review Comment:
warning: unknown type name 'rowid_t' [clang-diagnostic-error]
```cpp
virtual Status read_by_rowids(const rowid_t* rowids, ordinal_t page_first_ordinal, size_t* n,
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org