You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@skywalking.apache.org by ChenYao <br...@163.com> on 2020/05/25 09:55:32 UTC
Profile analyse
The thread pool in ProfileTaskExecution Service does not remove tasks that have already been performed.
Re: Re: Profile analyse
Posted by han liu <mr...@gmail.com>.
Hi,
First of all, thank you for review our new version code.
In the `ProfileTaskExecution`, we use PROFILE_TASK_SCHEDULE to schedule the
profile task to start the processing, it will schedule at the task start
time.
And using PROFILE_EXECUTOR to process the profile task, and It will finish
at the task finish. We using duration as the task execution max time.
So we don’t need to directly remove the task.
ChenYao <br...@163.com> 于2020年5月25日周一 下午6:14写道：
> The single-threaded pool PROFILE_TASK_SCHEDULE and PROFILE_EXECUTOR in
> the Discovery ProfileTaskExecution Service,
> which is currently learning the new version of the code review code, will
> always add task,
> and no code has been found to remove the end of the task in the queue...
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> 在 2020-05-25 18:00:51，"Sheng Wu" <wu...@gmail.com> 写道：
> >I think you should provide more than this. Or even provide a pull request
> >to fix this, if you have known what happens.
> >Basically, I don't how you get this a single statement conclusion.
> >It seems no context.
> >
> >Sheng Wu 吴晟
> >Twitter, wusheng1108
> >
> >
> >ChenYao <br...@163.com> 于2020年5月25日周一 下午5:55写道：
> >
> >> The thread pool in ProfileTaskExecution Service does not remove tasks
> that
> >> have already been performed.
> >>
> >>
>
Re:Re: Profile analyse
Posted by ChenYao <br...@163.com>.
The single-threaded pool PROFILE_TASK_SCHEDULE and PROFILE_EXECUTOR in the Discovery ProfileTaskExecution Service,
which is currently learning the new version of the code review code, will always add task,
and no code has been found to remove the end of the task in the queue...
在 2020-05-25 18:00:51，"Sheng Wu" <wu...@gmail.com> 写道：
>I think you should provide more than this. Or even provide a pull request
>to fix this, if you have known what happens.
>Basically, I don't how you get this a single statement conclusion.
>It seems no context.
>
>Sheng Wu 吴晟
>Twitter, wusheng1108
>
>
>ChenYao <br...@163.com> 于2020年5月25日周一 下午5:55写道：
>
>> The thread pool in ProfileTaskExecution Service does not remove tasks that
>> have already been performed.
>>
>>
Re: Profile analyse
Posted by Sheng Wu <wu...@gmail.com>.
I think you should provide more than this. Or even provide a pull request
to fix this, if you have known what happens.
Basically, I don't how you get this a single statement conclusion.
It seems no context.
Sheng Wu 吴晟
Twitter, wusheng1108
ChenYao <br...@163.com> 于2020年5月25日周一 下午5:55写道：
> The thread pool in ProfileTaskExecution Service does not remove tasks that
> have already been performed.
>
>