You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Vaibhav Gumashta <vg...@hortonworks.com> on 2016/01/17 00:34:28 UTC
Review Request 42392: HIVE-12049: WIP Patch: Add a serde to serialize
JDBC ResultSet in Tasks
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42392/
-----------------------------------------------------------
Review request for hive, Rohit Dholakia and Thejas Nair.
Bugs: HIVE-12049
https://issues.apache.org/jira/browse/HIVE-12049
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-12049
Diffs
-----
jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java 98d0370
jdbc/src/java/org/apache/hive/jdbc/HiveResultSetMetaData.java 16a0894
jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java 691fd0e
serde/pom.xml e025a4e
serde/src/java/org/apache/hadoop/hive/serde2/thrift/ColumnBuffer.java PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/thrift/ThriftJDBCBinarySerDe.java PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/thrift/Type.java PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfo.java 70dc181
service/src/java/org/apache/hive/service/cli/Column.java 102d920
service/src/java/org/apache/hive/service/cli/ColumnBasedSet.java b7fe663
service/src/java/org/apache/hive/service/cli/ColumnDescriptor.java 7bd9f06
service/src/java/org/apache/hive/service/cli/ColumnValue.java 37460e6
service/src/java/org/apache/hive/service/cli/TableSchema.java 2206e2c
service/src/java/org/apache/hive/service/cli/Type.java f067b3d
service/src/java/org/apache/hive/service/cli/TypeDescriptor.java b4a5b77
service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java 35b6c52
service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java 8db2e62
service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java 2a0fec2
service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a
service/src/test/org/apache/hive/service/cli/TestColumn.java 87bf848
Diff: https://reviews.apache.org/r/42392/diff/
Testing
-------
WIP Patch while I cleanup my local commits to generate complete patch(es). But will be useful to get review started. Limited testing done as of now.
Thanks,
Vaibhav Gumashta
Re: Review Request 42392: HIVE-12049: WIP Patch: Add a serde to
serialize JDBC ResultSet in Tasks
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42392/
-----------------------------------------------------------
(Updated Feb. 12, 2016, 2:48 a.m.)
Review request for hive, Rohit Dholakia and Thejas Nair.
Bugs: HIVE-12049
https://issues.apache.org/jira/browse/HIVE-12049
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-12049
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2c25cae
jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java 98d0370
jdbc/src/java/org/apache/hive/jdbc/HiveResultSetMetaData.java 16a0894
jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java b4dba44
jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java 691fd0e
ql/src/java/org/apache/hadoop/hive/ql/Driver.java 020f037
ql/src/java/org/apache/hadoop/hive/ql/exec/DefaultFetchFormatter.java b8be3a5
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchFormatter.java c2ed0d6
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java a5489a9
ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 32bfcf5
ql/src/java/org/apache/hadoop/hive/ql/exec/ListSinkOperator.java 919e72f
ql/src/java/org/apache/hadoop/hive/ql/parse/QB.java f04b493
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java c38699d
ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java a8f9f50
ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 5bea6fb
serde/pom.xml e025a4e
serde/src/java/org/apache/hadoop/hive/serde2/DefaultFetchFormatter.java PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/FetchFormatter.java PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/NoOpFetchFormatter.java PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java 90439a2
serde/src/java/org/apache/hadoop/hive/serde2/thrift/ColumnBuffer.java PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/thrift/ThriftFormatter.java PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/thrift/ThriftJDBCBinarySerDe.java PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/thrift/Type.java PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfo.java 70dc181
service-rpc/if/TCLIService.thrift 0aa9d13
service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 5364293
service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp e62e8b7
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TRowSet.java 2f6e31c
service-rpc/src/gen/thrift/gen-php/Types.php 76805df
service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py ef5f5f5
service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb f004ec4
service/src/java/org/apache/hive/service/cli/CLIService.java 0d5ae1e
service/src/java/org/apache/hive/service/cli/Column.java 102d920
service/src/java/org/apache/hive/service/cli/ColumnBasedSet.java b7fe663
service/src/java/org/apache/hive/service/cli/ColumnDescriptor.java 7bd9f06
service/src/java/org/apache/hive/service/cli/ColumnValue.java 37460e6
service/src/java/org/apache/hive/service/cli/RowBasedSet.java a80bac5
service/src/java/org/apache/hive/service/cli/RowSet.java 60d79dc
service/src/java/org/apache/hive/service/cli/RowSetFactory.java 1c2ff7f
service/src/java/org/apache/hive/service/cli/TableSchema.java 2206e2c
service/src/java/org/apache/hive/service/cli/Type.java f067b3d
service/src/java/org/apache/hive/service/cli/TypeDescriptor.java b4a5b77
service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java 8868ec1
service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java 35b6c52
service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java 8db2e62
service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java d6f6280
service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java a09b39a
service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java 740b851
service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java 2a0fec2
service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java f5a9771
service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 92135cd
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 2eaab4a
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 3c5700b
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 78b4b31
service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a
service/src/test/org/apache/hive/service/cli/TestColumn.java 87bf848
service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java 55a325d
Diff: https://reviews.apache.org/r/42392/diff/
Testing
-------
WIP Patch while I cleanup my local commits to generate complete patch(es). But will be useful to get review started. Limited testing done as of now.
Thanks,
Vaibhav Gumashta
Re: Review Request 42392: HIVE-12049: WIP Patch: Add a serde to
serialize JDBC ResultSet in Tasks
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42392/
-----------------------------------------------------------
(Updated Feb. 10, 2016, 11:48 p.m.)
Review request for hive, Rohit Dholakia and Thejas Nair.
Changes
-------
End to end patch
Bugs: HIVE-12049
https://issues.apache.org/jira/browse/HIVE-12049
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-12049
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2c25cae
jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java 98d0370
jdbc/src/java/org/apache/hive/jdbc/HiveResultSetMetaData.java 16a0894
jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java b4dba44
jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java 691fd0e
ql/src/java/org/apache/hadoop/hive/ql/Driver.java 020f037
ql/src/java/org/apache/hadoop/hive/ql/exec/DefaultFetchFormatter.java b8be3a5
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchFormatter.java c2ed0d6
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java a5489a9
ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 32bfcf5
ql/src/java/org/apache/hadoop/hive/ql/exec/ListSinkOperator.java 919e72f
ql/src/java/org/apache/hadoop/hive/ql/parse/QB.java f04b493
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java c38699d
ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java a8f9f50
ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 5bea6fb
serde/pom.xml e025a4e
serde/src/java/org/apache/hadoop/hive/serde2/DefaultFetchFormatter.java PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/FetchFormatter.java PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/NoOpFetchFormatter.java PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java 90439a2
serde/src/java/org/apache/hadoop/hive/serde2/thrift/ColumnBuffer.java PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/thrift/ThriftFormatter.java PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/thrift/ThriftJDBCBinarySerDe.java PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/thrift/Type.java PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfo.java 70dc181
service-rpc/if/TCLIService.thrift 0aa9d13
service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 5364293
service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp e62e8b7
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TRowSet.java 2f6e31c
service-rpc/src/gen/thrift/gen-php/Types.php 76805df
service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py ef5f5f5
service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb f004ec4
service/src/java/org/apache/hive/service/cli/CLIService.java 0d5ae1e
service/src/java/org/apache/hive/service/cli/Column.java 102d920
service/src/java/org/apache/hive/service/cli/ColumnBasedSet.java b7fe663
service/src/java/org/apache/hive/service/cli/ColumnDescriptor.java 7bd9f06
service/src/java/org/apache/hive/service/cli/ColumnValue.java 37460e6
service/src/java/org/apache/hive/service/cli/RowBasedSet.java a80bac5
service/src/java/org/apache/hive/service/cli/RowSet.java 60d79dc
service/src/java/org/apache/hive/service/cli/RowSetFactory.java 1c2ff7f
service/src/java/org/apache/hive/service/cli/TableSchema.java 2206e2c
service/src/java/org/apache/hive/service/cli/Type.java f067b3d
service/src/java/org/apache/hive/service/cli/TypeDescriptor.java b4a5b77
service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java 8868ec1
service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java 35b6c52
service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java 8db2e62
service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java d6f6280
service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java a09b39a
service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java 740b851
service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java 2a0fec2
service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java f5a9771
service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 92135cd
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 2eaab4a
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 3c5700b
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 78b4b31
service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a
service/src/test/org/apache/hive/service/cli/TestColumn.java 87bf848
service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java 55a325d
Diff: https://reviews.apache.org/r/42392/diff/
Testing
-------
WIP Patch while I cleanup my local commits to generate complete patch(es). But will be useful to get review started. Limited testing done as of now.
Thanks,
Vaibhav Gumashta
Re: Review Request 42392: HIVE-12049: WIP Patch: Add a serde to
serialize JDBC ResultSet in Tasks
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42392/
-----------------------------------------------------------
(Updated Jan. 18, 2016, 10:36 a.m.)
Review request for hive, Rohit Dholakia and Thejas Nair.
Bugs: HIVE-12049
https://issues.apache.org/jira/browse/HIVE-12049
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-12049
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2c25cae
jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java 98d0370
jdbc/src/java/org/apache/hive/jdbc/HiveResultSetMetaData.java 16a0894
jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java 691fd0e
ql/src/java/org/apache/hadoop/hive/ql/exec/DefaultFetchFormatter.java b8be3a5
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchFormatter.java c2ed0d6
ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 32bfcf5
ql/src/java/org/apache/hadoop/hive/ql/exec/ListSinkOperator.java 919e72f
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java c38699d
ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java a8f9f50
ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 5bea6fb
serde/pom.xml e025a4e
serde/src/java/org/apache/hadoop/hive/serde2/DefaultFetchFormatter.java PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/FetchFormatter.java PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java 90439a2
serde/src/java/org/apache/hadoop/hive/serde2/thrift/ColumnBuffer.java PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/thrift/ThriftFormatter.java PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/thrift/ThriftJDBCBinarySerDe.java PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/thrift/Type.java PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfo.java 70dc181
service/src/java/org/apache/hive/service/cli/Column.java 102d920
service/src/java/org/apache/hive/service/cli/ColumnBasedSet.java b7fe663
service/src/java/org/apache/hive/service/cli/ColumnDescriptor.java 7bd9f06
service/src/java/org/apache/hive/service/cli/ColumnValue.java 37460e6
service/src/java/org/apache/hive/service/cli/TableSchema.java 2206e2c
service/src/java/org/apache/hive/service/cli/Type.java f067b3d
service/src/java/org/apache/hive/service/cli/TypeDescriptor.java b4a5b77
service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java 35b6c52
service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java 8db2e62
service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java 2a0fec2
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 3c5700b
service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a
service/src/test/org/apache/hive/service/cli/TestColumn.java 87bf848
Diff: https://reviews.apache.org/r/42392/diff/
Testing
-------
WIP Patch while I cleanup my local commits to generate complete patch(es). But will be useful to get review started. Limited testing done as of now.
Thanks,
Vaibhav Gumashta
Re: Review Request 42392: HIVE-12049: WIP Patch: Add a serde to
serialize JDBC ResultSet in Tasks
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42392/
-----------------------------------------------------------
(Updated Jan. 18, 2016, 5:03 a.m.)
Review request for hive, Rohit Dholakia and Thejas Nair.
Bugs: HIVE-12049
https://issues.apache.org/jira/browse/HIVE-12049
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-12049
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2c25cae
jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java 98d0370
jdbc/src/java/org/apache/hive/jdbc/HiveResultSetMetaData.java 16a0894
jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java 691fd0e
ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 32bfcf5
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java c38699d
ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java a8f9f50
ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 5bea6fb
serde/pom.xml e025a4e
serde/src/java/org/apache/hadoop/hive/serde2/thrift/ColumnBuffer.java PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/thrift/ThriftJDBCBinarySerDe.java PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/thrift/Type.java PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfo.java 70dc181
service/src/java/org/apache/hive/service/cli/Column.java 102d920
service/src/java/org/apache/hive/service/cli/ColumnBasedSet.java b7fe663
service/src/java/org/apache/hive/service/cli/ColumnDescriptor.java 7bd9f06
service/src/java/org/apache/hive/service/cli/ColumnValue.java 37460e6
service/src/java/org/apache/hive/service/cli/TableSchema.java 2206e2c
service/src/java/org/apache/hive/service/cli/Type.java f067b3d
service/src/java/org/apache/hive/service/cli/TypeDescriptor.java b4a5b77
service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java 35b6c52
service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java 8db2e62
service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java 2a0fec2
service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a
service/src/test/org/apache/hive/service/cli/TestColumn.java 87bf848
Diff: https://reviews.apache.org/r/42392/diff/
Testing
-------
WIP Patch while I cleanup my local commits to generate complete patch(es). But will be useful to get review started. Limited testing done as of now.
Thanks,
Vaibhav Gumashta