You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/29 15:58:25 UTC

[GitHub] [flink] BiGsuw commented on a diff in pull request #19590: [FLINK-27352][tests] [JUnit5 Migration] Module: flink-json

BiGsuw commented on code in PR #19590:
URL: https://github.com/apache/flink/pull/19590#discussion_r861939399


##########
flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/debezium/DebeziumJsonSerDeSchemaTest.java:
##########
@@ -318,7 +307,7 @@ private void testDeserializationWithMetadata(
         final SimpleCollector collector = new SimpleCollector();
         deserializationSchema.deserialize(firstLine.getBytes(StandardCharsets.UTF_8), collector);
 
-        assertEquals(1, collector.list.size());
+        assertThat(collector.list.size()).isEqualTo(1);
         testConsumer.accept(collector.list.get(0));

Review Comment:
   I  use assertThat(collector.list).hasSize(1)  replace  assertThat(collector.list.size()).isEqualTo(1)  ，however I don't know how to use the sa method here, can you give me an example，thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org