You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/04/06 08:06:47 UTC
[GitHub] [hive] deniskuzZ opened a new pull request, #3181: HIVE-22420: Addendum
deniskuzZ opened a new pull request, #3181:
URL: https://github.com/apache/hive/pull/3181
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Proper ACID handling in case of operation interruption
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a diff in pull request #3181: HIVE-26121: Hive transaction rollback should be thread-safe
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on code in PR #3181:
URL: https://github.com/apache/hive/pull/3181#discussion_r843829383
##########
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java:
##########
@@ -710,49 +691,32 @@ private Heartbeater startHeartbeat(long initialDelay) throws LockException {
return task;
}
- private void stopHeartbeat() {
- if (heartbeatTask == null) {
- // avoid unnecessary locking if the field is null
- return;
- }
-
- boolean isLockAcquired = false;
- try {
- // The lock should not be held by other thread trying to stop the heartbeat for more than 31 seconds
- isLockAcquired = heartbeatTaskLock.tryLock(31000, TimeUnit.MILLISECONDS);
- } catch (InterruptedException e) {
- // safe to go on
- }
-
- try {
- if (isLockAcquired && heartbeatTask != null) {
- heartbeatTask.cancel(true);
- long startTime = System.currentTimeMillis();
- long sleepInterval = 100;
- while (!heartbeatTask.isCancelled() && !heartbeatTask.isDone()) {
- // We will wait for 30 seconds for the task to be cancelled.
- // If it's still not cancelled (unlikely), we will just move on.
- long now = System.currentTimeMillis();
- if (now - startTime > 30000) {
- LOG.warn("Heartbeat task cannot be cancelled for unknown reason. QueryId: " + queryId);
- break;
- }
- try {
- Thread.sleep(sleepInterval);
- } catch (InterruptedException e) {
- }
- sleepInterval *= 2;
+ private synchronized void stopHeartbeat() {
Review Comment:
added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on pull request #3181: HIVE-26121: Hive transaction rollback should be thread-safe
Posted by GitBox <gi...@apache.org>.
pvary commented on PR #3181:
URL: https://github.com/apache/hive/pull/3181#issuecomment-1091622189
I have missed this before, but do we really need to synchronize `DriverTxnHandler.endTransactionAndCleanup` and `DbTxnManager.java.stopHeartbeat` too?
Otherwise LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a diff in pull request #3181: HIVE-22420: Addendum
Posted by GitBox <gi...@apache.org>.
pvary commented on code in PR #3181:
URL: https://github.com/apache/hive/pull/3181#discussion_r843745809
##########
ql/src/java/org/apache/hadoop/hive/ql/DriverTxnHandler.java:
##########
@@ -570,7 +570,7 @@ void endTransactionAndCleanup(boolean commit) throws LockException {
txnRollbackRunner = null;
}
- void endTransactionAndCleanup(boolean commit, HiveTxnManager txnManager) throws LockException {
+ synchronized void endTransactionAndCleanup(boolean commit, HiveTxnManager txnManager) throws LockException {
Review Comment:
Could we leave a comment here, why is this synchronized?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a diff in pull request #3181: HIVE-26121: Hive transaction rollback should be thread-safe
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on code in PR #3181:
URL: https://github.com/apache/hive/pull/3181#discussion_r843829613
##########
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java:
##########
@@ -574,30 +571,24 @@ public void rollbackTxn() throws LockException {
if (!isTxnOpen()) {
throw new RuntimeException("Attempt to rollback before opening a transaction");
}
- stopHeartbeat();
-
try {
- lockMgr.clearLocalLockRecords();
+ clearLocksAndHB();
LOG.debug("Rolling back " + JavaUtils.txnIdToString(txnId));
-
- // Re-checking as txn could have been closed, in the meantime, by a competing thread.
- if (isTxnOpen()) {
- if (replPolicy != null) {
- getMS().replRollbackTxn(txnId, replPolicy, TxnType.DEFAULT);
- } else {
- getMS().rollbackTxn(txnId);
- }
+
+ if (replPolicy != null) {
Review Comment:
marked as @NotThreadSafe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ merged pull request #3181: HIVE-26121: Hive transaction rollback should be thread-safe
Posted by GitBox <gi...@apache.org>.
deniskuzZ merged PR #3181:
URL: https://github.com/apache/hive/pull/3181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a diff in pull request #3181: HIVE-22420: Addendum
Posted by GitBox <gi...@apache.org>.
pvary commented on code in PR #3181:
URL: https://github.com/apache/hive/pull/3181#discussion_r843750551
##########
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java:
##########
@@ -710,49 +691,32 @@ private Heartbeater startHeartbeat(long initialDelay) throws LockException {
return task;
}
- private void stopHeartbeat() {
- if (heartbeatTask == null) {
- // avoid unnecessary locking if the field is null
- return;
- }
-
- boolean isLockAcquired = false;
- try {
- // The lock should not be held by other thread trying to stop the heartbeat for more than 31 seconds
- isLockAcquired = heartbeatTaskLock.tryLock(31000, TimeUnit.MILLISECONDS);
- } catch (InterruptedException e) {
- // safe to go on
- }
-
- try {
- if (isLockAcquired && heartbeatTask != null) {
- heartbeatTask.cancel(true);
- long startTime = System.currentTimeMillis();
- long sleepInterval = 100;
- while (!heartbeatTask.isCancelled() && !heartbeatTask.isDone()) {
- // We will wait for 30 seconds for the task to be cancelled.
- // If it's still not cancelled (unlikely), we will just move on.
- long now = System.currentTimeMillis();
- if (now - startTime > 30000) {
- LOG.warn("Heartbeat task cannot be cancelled for unknown reason. QueryId: " + queryId);
- break;
- }
- try {
- Thread.sleep(sleepInterval);
- } catch (InterruptedException e) {
- }
- sleepInterval *= 2;
+ private synchronized void stopHeartbeat() {
Review Comment:
Comment here as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a diff in pull request #3181: HIVE-22420: Addendum
Posted by GitBox <gi...@apache.org>.
pvary commented on code in PR #3181:
URL: https://github.com/apache/hive/pull/3181#discussion_r843750056
##########
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java:
##########
@@ -574,30 +571,24 @@ public void rollbackTxn() throws LockException {
if (!isTxnOpen()) {
throw new RuntimeException("Attempt to rollback before opening a transaction");
}
- stopHeartbeat();
-
try {
- lockMgr.clearLocalLockRecords();
+ clearLocksAndHB();
LOG.debug("Rolling back " + JavaUtils.txnIdToString(txnId));
-
- // Re-checking as txn could have been closed, in the meantime, by a competing thread.
- if (isTxnOpen()) {
- if (replPolicy != null) {
- getMS().replRollbackTxn(txnId, replPolicy, TxnType.DEFAULT);
- } else {
- getMS().rollbackTxn(txnId);
- }
+
+ if (replPolicy != null) {
Review Comment:
If we expect that this class should not be shared between threads, then we should write a comment on the class level for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a diff in pull request #3181: HIVE-26121: Hive transaction rollback should be thread-safe
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on code in PR #3181:
URL: https://github.com/apache/hive/pull/3181#discussion_r843829763
##########
ql/src/java/org/apache/hadoop/hive/ql/DriverTxnHandler.java:
##########
@@ -570,7 +570,7 @@ void endTransactionAndCleanup(boolean commit) throws LockException {
txnRollbackRunner = null;
}
- void endTransactionAndCleanup(boolean commit, HiveTxnManager txnManager) throws LockException {
+ synchronized void endTransactionAndCleanup(boolean commit, HiveTxnManager txnManager) throws LockException {
Review Comment:
added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on pull request #3181: HIVE-26121: Hive transaction rollback should be thread-safe
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on PR #3181:
URL: https://github.com/apache/hive/pull/3181#issuecomment-1094709982
> endTransactionAndCleanup
yes, we definitely need to synchronize `DriverTxnHandler.endTransactionAndCleanup`. As for `DbTxnManager.java.stopHeartbeat` it was already kinda synchronized and it's possible that concurrent execution might still occur when shutdownhook is invoked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org