You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Dave Smith (JIRA)" <ji...@apache.org> on 2008/05/03 02:26:55 UTC
[jira] Created: (SHINDIG-221) Add an AllTests suite for running
tests from Eclipse
Add an AllTests suite for running tests from Eclipse
----------------------------------------------------
Key: SHINDIG-221
URL: https://issues.apache.org/jira/browse/SHINDIG-221
Project: Shindig
Issue Type: Test
Components: Common Components (Java)
Environment: Linux/Eclipse
Reporter: Dave Smith
Priority: Minor
Getting coverage numbers from within Eclipse needed an AllTests suite, so I wrote one.
junit-addons provides DirectorySuiteBuilder.
Note that because of the way the code is structured, the tests in the org.apache.shindig.util package don't get run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-221) Add an AllTests suite for running
tests from Eclipse
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596833#action_12596833 ]
Kevin Brown commented on SHINDIG-221:
-------------------------------------
A separate AllTests for each artifact is fine (the code is tiny), and in fact that is the desired behavior. There's no good reason to require running gadget rendering tests when you build the RESTful API, and there's no reason to run RESTful tests when you're building the gadget renderer.
On the other hand, running both artifact's tests is a requirement if anything in the common artifact is changed, so if there is going to be only one AllTests, it belongs in the common artifact, NOT gadgets.
> Add an AllTests suite for running tests from Eclipse
> ----------------------------------------------------
>
> Key: SHINDIG-221
> URL: https://issues.apache.org/jira/browse/SHINDIG-221
> Project: Shindig
> Issue Type: Test
> Components: Common Components (Java)
> Environment: Linux/Eclipse
> Reporter: Dave Smith
> Priority: Minor
> Attachments: SHINDIG-221-AllTests.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Getting coverage numbers from within Eclipse needed an AllTests suite, so I wrote one.
> junit-addons provides DirectorySuiteBuilder.
> Note that because of the way the code is structured, the tests in the org.apache.shindig.util package don't get run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-221) Add an AllTests suite for running
tests from Eclipse
Posted by "Dave Smith (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Smith updated SHINDIG-221:
-------------------------------
Attachment: AllTests.patch
Changes correspond to revision 652958.
> Add an AllTests suite for running tests from Eclipse
> ----------------------------------------------------
>
> Key: SHINDIG-221
> URL: https://issues.apache.org/jira/browse/SHINDIG-221
> Project: Shindig
> Issue Type: Test
> Components: Common Components (Java)
> Environment: Linux/Eclipse
> Reporter: Dave Smith
> Priority: Minor
> Attachments: AllTests.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Getting coverage numbers from within Eclipse needed an AllTests suite, so I wrote one.
> junit-addons provides DirectorySuiteBuilder.
> Note that because of the way the code is structured, the tests in the org.apache.shindig.util package don't get run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-221) Add an AllTests suite for running
tests from Eclipse
Posted by "Vincent Siveton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593993#action_12593993 ]
Vincent Siveton commented on SHINDIG-221:
-----------------------------------------
I bet you want use "target/test-classes" instead of ""target/classes"
> Add an AllTests suite for running tests from Eclipse
> ----------------------------------------------------
>
> Key: SHINDIG-221
> URL: https://issues.apache.org/jira/browse/SHINDIG-221
> Project: Shindig
> Issue Type: Test
> Components: Common Components (Java)
> Environment: Linux/Eclipse
> Reporter: Dave Smith
> Priority: Minor
> Attachments: AllTests.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Getting coverage numbers from within Eclipse needed an AllTests suite, so I wrote one.
> junit-addons provides DirectorySuiteBuilder.
> Note that because of the way the code is structured, the tests in the org.apache.shindig.util package don't get run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-221) Add an AllTests suite for running
tests from Eclipse
Posted by "Dave Smith (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Smith updated SHINDIG-221:
-------------------------------
Attachment: SHINDIG-221-AllTests.patch
Regenerated patch to reflect changes in sites/index.html.
Added instructions for running code coverage.
> Add an AllTests suite for running tests from Eclipse
> ----------------------------------------------------
>
> Key: SHINDIG-221
> URL: https://issues.apache.org/jira/browse/SHINDIG-221
> Project: Shindig
> Issue Type: Test
> Components: Common Components (Java)
> Environment: Linux/Eclipse
> Reporter: Dave Smith
> Priority: Minor
> Attachments: SHINDIG-221-AllTests.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Getting coverage numbers from within Eclipse needed an AllTests suite, so I wrote one.
> junit-addons provides DirectorySuiteBuilder.
> Note that because of the way the code is structured, the tests in the org.apache.shindig.util package don't get run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-221) Add an AllTests suite for running
tests from Eclipse
Posted by "Dave Smith (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594349#action_12594349 ]
Dave Smith commented on SHINDIG-221:
------------------------------------
You're right. I was letting Eclipse get away with default behavior.
I'll regenerate the patch, and will include additional detail on getting Eclipse set up correctly.
> Add an AllTests suite for running tests from Eclipse
> ----------------------------------------------------
>
> Key: SHINDIG-221
> URL: https://issues.apache.org/jira/browse/SHINDIG-221
> Project: Shindig
> Issue Type: Test
> Components: Common Components (Java)
> Environment: Linux/Eclipse
> Reporter: Dave Smith
> Priority: Minor
> Attachments: AllTests.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Getting coverage numbers from within Eclipse needed an AllTests suite, so I wrote one.
> junit-addons provides DirectorySuiteBuilder.
> Note that because of the way the code is structured, the tests in the org.apache.shindig.util package don't get run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-221) Add an AllTests suite for running
tests from Eclipse
Posted by "Dave Smith (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Smith updated SHINDIG-221:
-------------------------------
Attachment: AllTests.patch
Rework patch to use target/test-classes.
Add to Eclipse setup doc so that Eclipse will use target/tests-classes.
> Add an AllTests suite for running tests from Eclipse
> ----------------------------------------------------
>
> Key: SHINDIG-221
> URL: https://issues.apache.org/jira/browse/SHINDIG-221
> Project: Shindig
> Issue Type: Test
> Components: Common Components (Java)
> Environment: Linux/Eclipse
> Reporter: Dave Smith
> Priority: Minor
> Attachments: AllTests.patch, AllTests.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Getting coverage numbers from within Eclipse needed an AllTests suite, so I wrote one.
> junit-addons provides DirectorySuiteBuilder.
> Note that because of the way the code is structured, the tests in the org.apache.shindig.util package don't get run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-221) Add an AllTests suite for running
tests from Eclipse
Posted by "Dave Smith (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Smith updated SHINDIG-221:
-------------------------------
Attachment: (was: AllTests.patch)
> Add an AllTests suite for running tests from Eclipse
> ----------------------------------------------------
>
> Key: SHINDIG-221
> URL: https://issues.apache.org/jira/browse/SHINDIG-221
> Project: Shindig
> Issue Type: Test
> Components: Common Components (Java)
> Environment: Linux/Eclipse
> Reporter: Dave Smith
> Priority: Minor
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Getting coverage numbers from within Eclipse needed an AllTests suite, so I wrote one.
> junit-addons provides DirectorySuiteBuilder.
> Note that because of the way the code is structured, the tests in the org.apache.shindig.util package don't get run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-221) Add an AllTests suite for running
tests from Eclipse
Posted by "Dave Smith (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596830#action_12596830 ]
Dave Smith commented on SHINDIG-221:
------------------------------------
It misses less than you'd think, but I agree that having AllTests under
gadgets looks odd.
I thought that moving it up a level in the package structure might be too
intrusive a change
at this point, and adding an AllTest for each top-level package seems like
duplication.
Leaving the jira open to get a decision on this is good. I'll stay on it.
Dave
> Add an AllTests suite for running tests from Eclipse
> ----------------------------------------------------
>
> Key: SHINDIG-221
> URL: https://issues.apache.org/jira/browse/SHINDIG-221
> Project: Shindig
> Issue Type: Test
> Components: Common Components (Java)
> Environment: Linux/Eclipse
> Reporter: Dave Smith
> Priority: Minor
> Attachments: SHINDIG-221-AllTests.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Getting coverage numbers from within Eclipse needed an AllTests suite, so I wrote one.
> junit-addons provides DirectorySuiteBuilder.
> Note that because of the way the code is structured, the tests in the org.apache.shindig.util package don't get run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-221) Add an AllTests suite for running
tests from Eclipse
Posted by "Dave Smith (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Smith updated SHINDIG-221:
-------------------------------
Attachment: SHINDIG-221-moveAllTests.patch
Per Kevin, move AllTest from gadgets to common.
> Add an AllTests suite for running tests from Eclipse
> ----------------------------------------------------
>
> Key: SHINDIG-221
> URL: https://issues.apache.org/jira/browse/SHINDIG-221
> Project: Shindig
> Issue Type: Test
> Components: Common Components (Java)
> Environment: Linux/Eclipse
> Reporter: Dave Smith
> Priority: Minor
> Attachments: SHINDIG-221-AllTests.patch, SHINDIG-221-moveAllTests.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Getting coverage numbers from within Eclipse needed an AllTests suite, so I wrote one.
> junit-addons provides DirectorySuiteBuilder.
> Note that because of the way the code is structured, the tests in the org.apache.shindig.util package don't get run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-221) Add an AllTests suite for running
tests from Eclipse
Posted by "Cassie Doll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596705#action_12596705 ]
Cassie Doll commented on SHINDIG-221:
-------------------------------------
This patch looks good except for the fact that it is missing a bunch of tests. Is there any way to make a test suite for eclipse that runs all of the common tests, the gadget tests and the social tests? I suppose we could make an AllTests target for each and then put a master AllTests somewhere else if worse comes to worse.
I don't have eclipse and thus don't know the best way to set that up for you. So, I will need some help.
For now, I'll check this initial patch in but leave the jira open.
> Add an AllTests suite for running tests from Eclipse
> ----------------------------------------------------
>
> Key: SHINDIG-221
> URL: https://issues.apache.org/jira/browse/SHINDIG-221
> Project: Shindig
> Issue Type: Test
> Components: Common Components (Java)
> Environment: Linux/Eclipse
> Reporter: Dave Smith
> Priority: Minor
> Attachments: SHINDIG-221-AllTests.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Getting coverage numbers from within Eclipse needed an AllTests suite, so I wrote one.
> junit-addons provides DirectorySuiteBuilder.
> Note that because of the way the code is structured, the tests in the org.apache.shindig.util package don't get run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.