You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "HattoriHenzo (via GitHub)" <gi...@apache.org> on 2023/04/20 23:57:47 UTC

[GitHub] [eventmesh] HattoriHenzo opened a new pull request, #3790: [ISSUE #860] Add unit test for MetricsPluginFactory class

HattoriHenzo opened a new pull request, #3790:
URL: https://github.com/apache/eventmesh/pull/3790

   Fixes https://github.com/apache/eventmesh/issues/860
   
   ### Motivation
   
   Add unit test for [eventmesh-metrics-plugin]
   
   
   ### Modifications
   
   *Describe the modifications you've done.*
   
   
   
   ### Documentation
   
   - Does this pull request introduce a new feature? (yes / no)
   - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   - If a feature is not applicable for documentation, explain why?
   - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [eventmesh] codecov[bot] commented on pull request #3790: [ISSUE #860] Add unit test for MetricsPluginFactory class

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3790:
URL: https://github.com/apache/eventmesh/pull/3790#issuecomment-1521092994

   ## [Codecov](https://codecov.io/gh/apache/eventmesh/pull/3790?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3790](https://codecov.io/gh/apache/eventmesh/pull/3790?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05c3429) into [master](https://codecov.io/gh/apache/eventmesh/commit/7d3bbde05289982d19ab39ff1a8f1c55a382e5d5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d3bbde) will **decrease** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 05c3429 differs from pull request most recent head bca5bf1. Consider uploading reports for the commit bca5bf1 to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3790      +/-   ##
   ============================================
   - Coverage     13.80%   13.79%   -0.02%     
   - Complexity     1291     1292       +1     
   ============================================
     Files           571      571              
     Lines         29154    29147       -7     
     Branches       2856     2844      -12     
   ============================================
   - Hits           4024     4020       -4     
   + Misses        24756    24754       -2     
   + Partials        374      373       -1     
   ```
   
   
   [see 9 files with indirect coverage changes](https://codecov.io/gh/apache/eventmesh/pull/3790/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


[GitHub] [eventmesh] xwm1992 merged pull request #3790: [ISSUE #860] Add unit test for MetricsPluginFactory class

Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3790:
URL: https://github.com/apache/eventmesh/pull/3790


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org