You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "erisu (via GitHub)" <gi...@apache.org> on 2025/07/22 10:07:59 UTC
[PR] feat!: remove support for create package json [cordova-lib]
erisu opened a new pull request, #953:
URL: https://github.com/apache/cordova-lib/pull/953
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Affects
`cordova-plugman`
### Motivation, Context & Description
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Remove legacy Plugman CLI-specific plugin creation logic.
* This logic is specific to **Plugman CLI**, which hasn't been updated or released since 2019.
* The functionality was not used by any other Apache Cordova tools.
* There appears to be a lack of documentation or support around this feature.
* The create plugin guide also removed references of `plugman` since.
Given the lack of documentation and that Plugman CLI is become outdate and buggy, I would be more inclined to **fully remove** this feature and not migrate it to `cordova-plugman`.
But as for this repo, I think this logic should not exist here.
As for `cordova-plugman`, others even suggest creating a dedicated plugin template with clear documentation would be more beneficial than the current process.
Third-party tools maybe also provide a more modern flow for creating plugins.
### Testing
<!-- Please describe in detail how you tested your changes. -->
- `npm t`
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] feat(plugman)!: remove create plugin support [cordova-lib]
Posted by "kumo01GitHub (via GitHub)" <gi...@apache.org>.
kumo01GitHub commented on PR #953:
URL: https://github.com/apache/cordova-lib/pull/953#issuecomment-3152676776
Or it might be my misunderstanding if you will remove function to create plugin from Plugman CLI and `cordova-lib` still supports Plugman CLI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] feat(plugman)!: remove create plugin support [cordova-lib]
Posted by "erisu (via GitHub)" <gi...@apache.org>.
erisu merged PR #953:
URL: https://github.com/apache/cordova-lib/pull/953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] feat!: remove support for create package json [cordova-lib]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #953:
URL: https://github.com/apache/cordova-lib/pull/953#issuecomment-3102034694
## [Codecov](https://app.codecov.io/gh/apache/cordova-lib/pull/953?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 91.10%. Comparing base [(`be76c00`)](https://app.codecov.io/gh/apache/cordova-lib/commit/be76c00df7b35f5663dbf94d01465fa0f20e3043?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`6ec9156`)](https://app.codecov.io/gh/apache/cordova-lib/commit/6ec915652d7c8452b1545b873ab484cde4cb1143?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #953 +/- ##
==========================================
+ Coverage 87.97% 91.10% +3.12%
==========================================
Files 46 44 -2
Lines 2146 2068 -78
==========================================
- Hits 1888 1884 -4
+ Misses 258 184 -74
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cordova-lib/pull/953?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] feat(plugman)!: remove create plugin support [cordova-lib]
Posted by "kumo01GitHub (via GitHub)" <gi...@apache.org>.
kumo01GitHub commented on PR #953:
URL: https://github.com/apache/cordova-lib/pull/953#issuecomment-3151223055
After drop `plugman` feature, is this repo need to be separate from Cordova cli?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] feat(plugman)!: remove create plugin support [cordova-lib]
Posted by "dpogue (via GitHub)" <gi...@apache.org>.
dpogue commented on PR #953:
URL: https://github.com/apache/cordova-lib/pull/953#issuecomment-3152684857
There are other non-ASF projects that depend on `cordova-lib` to implement their own CLI functionality, so IMO it makes sense for `cordova-lib` to still exist and for `cordova-cli` to be a wrapper over top of it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] feat(plugman)!: remove create plugin support [cordova-lib]
Posted by "kumo01GitHub (via GitHub)" <gi...@apache.org>.
kumo01GitHub commented on PR #953:
URL: https://github.com/apache/cordova-lib/pull/953#issuecomment-3152651988
I mean that you can migrate all of remained function to Cordova CLI repo. Because after this change,
Plugman CLI cannot update `cordova-lib` and `cordova-lib` is only for Cordova CLI.
I assumed that this module manages common functions for Cordova CLI and Plugman CLI. So, I wonder that this module should be migrated to Cordova CLI or not after this module doesn't support Plugman CLI any more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] feat(plugman)!: remove create plugin support [cordova-lib]
Posted by "erisu (via GitHub)" <gi...@apache.org>.
erisu commented on PR #953:
URL: https://github.com/apache/cordova-lib/pull/953#issuecomment-3151434782
> is this repo need to be separated from Cordova cli?
No, Cordova-CLI still needs `cordova-lib` to function.
Removing this feature does not effect to Cordova-CLI. Cordova-CLI has never used this specific plugman feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] feat(plugman)!: remove create plugin support [cordova-lib]
Posted by "kumo01GitHub (via GitHub)" <gi...@apache.org>.
kumo01GitHub commented on PR #953:
URL: https://github.com/apache/cordova-lib/pull/953#issuecomment-3152693886
I understood. This repo will be remained for third-party modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org