You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2023/07/19 04:10:20 UTC

[kudu-CR](branch-1.17.x) Remove the supporting of EOL macOS 10.x

Hello Marton Greber, Alexey Serbin, Yifan Zhang,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/20223

to review the following change.


Change subject: Remove the supporting of EOL macOS 10.x
......................................................................

Remove the supporting of EOL macOS 10.x

macOS 10.15 is EOL in November, 2022 [1], we can
remove the supporting clarification.

Besides, update build_mini_cluster_binaries.sh
to skip copying '/usr/lib/libc++abi.dylib'
because it can not be accessed since macOS 11 [2].

1. https://computing.cs.cmu.edu/news/2022/eol-macos-catalina
2. https://developer.apple.com/documentation/macos-release-notes/macos-big-sur-11_0_1-release-notes#Kernel

Change-Id: Ifd0658eef8ee8b275e50d49f504c23de9615a5d7
Reviewed-on: http://gerrit.cloudera.org:8080/20185
Reviewed-by: Marton Greber <gr...@gmail.com>
Tested-by: Yingchun Lai <la...@apache.org>
Reviewed-by: Yifan Zhang <ch...@163.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 5659541d15c5490d25ca207c4f63b249986fbfe6)
---
M RELEASING.adoc
M build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
M docs/developing.adoc
M docs/installation.adoc
4 files changed, 5 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/20223/1
-- 
To view, visit http://gerrit.cloudera.org:8080/20223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd0658eef8ee8b275e50d49f504c23de9615a5d7
Gerrit-Change-Number: 20223
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>

[kudu-CR](branch-1.17.x) Remove the supporting of EOL macOS 10.x

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20223 )

Change subject: Remove the supporting of EOL macOS 10.x
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd0658eef8ee8b275e50d49f504c23de9615a5d7
Gerrit-Change-Number: 20223
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 19 Jul 2023 05:51:32 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) Remove the supporting of EOL macOS 10.x

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20223 )

Change subject: Remove the supporting of EOL macOS 10.x
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/20223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd0658eef8ee8b275e50d49f504c23de9615a5d7
Gerrit-Change-Number: 20223
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 19 Jul 2023 15:06:21 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) Remove the supporting of EOL macOS 10.x

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20223 )

Change subject: Remove the supporting of EOL macOS 10.x
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/20223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd0658eef8ee8b275e50d49f504c23de9615a5d7
Gerrit-Change-Number: 20223
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Wed, 19 Jul 2023 15:48:03 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) Remove the supporting of EOL macOS 10.x

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.

Change subject: Remove the supporting of EOL macOS 10.x
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/20223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ifd0658eef8ee8b275e50d49f504c23de9615a5d7
Gerrit-Change-Number: 20223
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>

[kudu-CR](branch-1.17.x) Remove the supporting of EOL macOS 10.x

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20223 )

Change subject: Remove the supporting of EOL macOS 10.x
......................................................................

Remove the supporting of EOL macOS 10.x

macOS 10.15 is EOL in November, 2022 [1], we can
remove the supporting clarification.

Besides, update build_mini_cluster_binaries.sh
to skip copying '/usr/lib/libc++abi.dylib'
because it can not be accessed since macOS 11 [2].

1. https://computing.cs.cmu.edu/news/2022/eol-macos-catalina
2. https://developer.apple.com/documentation/macos-release-notes/macos-big-sur-11_0_1-release-notes#Kernel

Change-Id: Ifd0658eef8ee8b275e50d49f504c23de9615a5d7
Reviewed-on: http://gerrit.cloudera.org:8080/20185
Reviewed-by: Marton Greber <gr...@gmail.com>
Tested-by: Yingchun Lai <la...@apache.org>
Reviewed-by: Yifan Zhang <ch...@163.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 5659541d15c5490d25ca207c4f63b249986fbfe6)
Reviewed-on: http://gerrit.cloudera.org:8080/20223
---
M RELEASING.adoc
M build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
M docs/developing.adoc
M docs/installation.adoc
4 files changed, 5 insertions(+), 6 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Marton Greber: Looks good to me, but someone else must approve
  Yingchun Lai: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/20223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd0658eef8ee8b275e50d49f504c23de9615a5d7
Gerrit-Change-Number: 20223
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>