You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "wombatu-kun (via GitHub)" <gi...@apache.org> on 2024/02/22 05:02:23 UTC
[PR] [HUDI-6089] Handle default insert behaviour to ingest duplicates [hudi]
wombatu-kun opened a new pull request, #10728:
URL: https://github.com/apache/hudi/pull/10728
### Change Logs
Made default value of "hoodie.merge.allow.duplicate.on.inserts" as True and fixed tests.
### Impact
low
### Risk level (write none, low medium or high below)
low
### Documentation Update
Documentation update is needed as default value of HoodieWriteConfig property "hoodie.merge.allow.duplicate.on.inserts" changed to true
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6089] Handle default insert behaviour to ingest duplicates [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10728:
URL: https://github.com/apache/hudi/pull/10728#issuecomment-1961420614
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6348547bbb296493bb2d137a9764199117784e10",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22555",
"triggerID" : "6348547bbb296493bb2d137a9764199117784e10",
"triggerType" : "PUSH"
}, {
"hash" : "22f875240369cab37842e58c9d504873643f10e1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22583",
"triggerID" : "22f875240369cab37842e58c9d504873643f10e1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22f875240369cab37842e58c9d504873643f10e1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22583)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6089] Handle default insert behaviour to ingest duplicates [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10728:
URL: https://github.com/apache/hudi/pull/10728#issuecomment-1958843247
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6348547bbb296493bb2d137a9764199117784e10",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22555",
"triggerID" : "6348547bbb296493bb2d137a9764199117784e10",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6348547bbb296493bb2d137a9764199117784e10 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22555)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6089] Handle default insert behaviour to ingest duplicates [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10728:
URL: https://github.com/apache/hudi/pull/10728#issuecomment-1965833757
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22f875240369cab37842e58c9d504873643f10e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22583",
"triggerID" : "22f875240369cab37842e58c9d504873643f10e1",
"triggerType" : "PUSH"
}, {
"hash" : "11a6e3dc51a557703b1db4f1160ee6d26fb17192",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22633",
"triggerID" : "11a6e3dc51a557703b1db4f1160ee6d26fb17192",
"triggerType" : "PUSH"
}, {
"hash" : "6ea9dfef741532eed8af624e70b0a44aae909f22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22634",
"triggerID" : "6ea9dfef741532eed8af624e70b0a44aae909f22",
"triggerType" : "PUSH"
}, {
"hash" : "337a99cbb58d9f1cf9d6c6f31099ce9b4fbda85f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22654",
"triggerID" : "337a99cbb58d9f1cf9d6c6f31099ce9b4fbda85f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 337a99cbb58d9f1cf9d6c6f31099ce9b4fbda85f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22654)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6089] Handle default insert behaviour to ingest duplicates [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10728:
URL: https://github.com/apache/hudi/pull/10728#issuecomment-1963303272
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22f875240369cab37842e58c9d504873643f10e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22583",
"triggerID" : "22f875240369cab37842e58c9d504873643f10e1",
"triggerType" : "PUSH"
}, {
"hash" : "11a6e3dc51a557703b1db4f1160ee6d26fb17192",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22633",
"triggerID" : "11a6e3dc51a557703b1db4f1160ee6d26fb17192",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11a6e3dc51a557703b1db4f1160ee6d26fb17192 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22633)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6089] Handle default insert behaviour to ingest duplicates [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10728:
URL: https://github.com/apache/hudi/pull/10728#issuecomment-1963026305
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22f875240369cab37842e58c9d504873643f10e1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22583",
"triggerID" : "22f875240369cab37842e58c9d504873643f10e1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22f875240369cab37842e58c9d504873643f10e1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22583)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6089] Handle default insert behaviour to ingest duplicates [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10728:
URL: https://github.com/apache/hudi/pull/10728#issuecomment-1961258025
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6348547bbb296493bb2d137a9764199117784e10",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22555",
"triggerID" : "6348547bbb296493bb2d137a9764199117784e10",
"triggerType" : "PUSH"
}, {
"hash" : "22f875240369cab37842e58c9d504873643f10e1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22583",
"triggerID" : "22f875240369cab37842e58c9d504873643f10e1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6348547bbb296493bb2d137a9764199117784e10 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22555)
* 22f875240369cab37842e58c9d504873643f10e1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22583)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6089] Handle default insert behaviour to ingest duplicates [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10728:
URL: https://github.com/apache/hudi/pull/10728#issuecomment-1965691572
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22f875240369cab37842e58c9d504873643f10e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22583",
"triggerID" : "22f875240369cab37842e58c9d504873643f10e1",
"triggerType" : "PUSH"
}, {
"hash" : "11a6e3dc51a557703b1db4f1160ee6d26fb17192",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22633",
"triggerID" : "11a6e3dc51a557703b1db4f1160ee6d26fb17192",
"triggerType" : "PUSH"
}, {
"hash" : "6ea9dfef741532eed8af624e70b0a44aae909f22",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22634",
"triggerID" : "6ea9dfef741532eed8af624e70b0a44aae909f22",
"triggerType" : "PUSH"
}, {
"hash" : "337a99cbb58d9f1cf9d6c6f31099ce9b4fbda85f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "337a99cbb58d9f1cf9d6c6f31099ce9b4fbda85f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6ea9dfef741532eed8af624e70b0a44aae909f22 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22634)
* 337a99cbb58d9f1cf9d6c6f31099ce9b4fbda85f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6089] Handle default insert behaviour to ingest duplicates [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10728:
URL: https://github.com/apache/hudi/pull/10728#issuecomment-1965697126
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22f875240369cab37842e58c9d504873643f10e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22583",
"triggerID" : "22f875240369cab37842e58c9d504873643f10e1",
"triggerType" : "PUSH"
}, {
"hash" : "11a6e3dc51a557703b1db4f1160ee6d26fb17192",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22633",
"triggerID" : "11a6e3dc51a557703b1db4f1160ee6d26fb17192",
"triggerType" : "PUSH"
}, {
"hash" : "6ea9dfef741532eed8af624e70b0a44aae909f22",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22634",
"triggerID" : "6ea9dfef741532eed8af624e70b0a44aae909f22",
"triggerType" : "PUSH"
}, {
"hash" : "337a99cbb58d9f1cf9d6c6f31099ce9b4fbda85f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22654",
"triggerID" : "337a99cbb58d9f1cf9d6c6f31099ce9b4fbda85f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6ea9dfef741532eed8af624e70b0a44aae909f22 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22634)
* 337a99cbb58d9f1cf9d6c6f31099ce9b4fbda85f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22654)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6089] Handle default insert behaviour to ingest duplicates [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10728:
URL: https://github.com/apache/hudi/pull/10728#issuecomment-1963601034
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22f875240369cab37842e58c9d504873643f10e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22583",
"triggerID" : "22f875240369cab37842e58c9d504873643f10e1",
"triggerType" : "PUSH"
}, {
"hash" : "11a6e3dc51a557703b1db4f1160ee6d26fb17192",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22633",
"triggerID" : "11a6e3dc51a557703b1db4f1160ee6d26fb17192",
"triggerType" : "PUSH"
}, {
"hash" : "6ea9dfef741532eed8af624e70b0a44aae909f22",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22634",
"triggerID" : "6ea9dfef741532eed8af624e70b0a44aae909f22",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11a6e3dc51a557703b1db4f1160ee6d26fb17192 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22633)
* 6ea9dfef741532eed8af624e70b0a44aae909f22 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22634)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6089] Handle default insert behaviour to ingest duplicates [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10728:
URL: https://github.com/apache/hudi/pull/10728#issuecomment-1963007845
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22f875240369cab37842e58c9d504873643f10e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "22f875240369cab37842e58c9d504873643f10e1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22f875240369cab37842e58c9d504873643f10e1 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6089] Handle default insert behaviour to ingest duplicates [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10728:
URL: https://github.com/apache/hudi/pull/10728#issuecomment-1963937057
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22f875240369cab37842e58c9d504873643f10e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22583",
"triggerID" : "22f875240369cab37842e58c9d504873643f10e1",
"triggerType" : "PUSH"
}, {
"hash" : "11a6e3dc51a557703b1db4f1160ee6d26fb17192",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22633",
"triggerID" : "11a6e3dc51a557703b1db4f1160ee6d26fb17192",
"triggerType" : "PUSH"
}, {
"hash" : "6ea9dfef741532eed8af624e70b0a44aae909f22",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22634",
"triggerID" : "6ea9dfef741532eed8af624e70b0a44aae909f22",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6ea9dfef741532eed8af624e70b0a44aae909f22 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22634)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6089] Handle default insert behaviour to ingest duplicates [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #10728:
URL: https://github.com/apache/hudi/pull/10728#discussion_r1501964777
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -562,7 +562,7 @@ public class HoodieWriteConfig extends HoodieConfig {
public static final ConfigProperty<String> MERGE_ALLOW_DUPLICATE_ON_INSERTS_ENABLE = ConfigProperty
.key("hoodie.merge.allow.duplicate.on.inserts")
- .defaultValue("false")
+ .defaultValue("true")
.markAdvanced()
Review Comment:
Okay, let's rebase with the latest master and make all the tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6089] Handle default insert behaviour to ingest duplicates [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #10728:
URL: https://github.com/apache/hudi/pull/10728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6089] Handle default insert behaviour to ingest duplicates [hudi]
Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.
wombatu-kun commented on PR #10728:
URL: https://github.com/apache/hudi/pull/10728#issuecomment-1975012557
update in documentation is already made: https://github.com/apache/hudi/pull/10739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6089] Handle default insert behaviour to ingest duplicates [hudi]
Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.
wombatu-kun commented on code in PR #10728:
URL: https://github.com/apache/hudi/pull/10728#discussion_r1501343613
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -562,7 +562,7 @@ public class HoodieWriteConfig extends HoodieConfig {
public static final ConfigProperty<String> MERGE_ALLOW_DUPLICATE_ON_INSERTS_ENABLE = ConfigProperty
.key("hoodie.merge.allow.duplicate.on.inserts")
- .defaultValue("false")
+ .defaultValue("true")
.markAdvanced()
Review Comment:
i think there is, as people writes tasks and issues: https://github.com/apache/hudi/issues/8451
https://issues.apache.org/jira/browse/HUDI-6089
https://issues.apache.org/jira/browse/HUDI-6346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6089] Handle default insert behaviour to ingest duplicates [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10728:
URL: https://github.com/apache/hudi/pull/10728#issuecomment-1963009679
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22f875240369cab37842e58c9d504873643f10e1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22583",
"triggerID" : "22f875240369cab37842e58c9d504873643f10e1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22f875240369cab37842e58c9d504873643f10e1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22583)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6089] Handle default insert behaviour to ingest duplicates [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10728:
URL: https://github.com/apache/hudi/pull/10728#issuecomment-1963223335
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22f875240369cab37842e58c9d504873643f10e1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22583",
"triggerID" : "22f875240369cab37842e58c9d504873643f10e1",
"triggerType" : "PUSH"
}, {
"hash" : "11a6e3dc51a557703b1db4f1160ee6d26fb17192",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "11a6e3dc51a557703b1db4f1160ee6d26fb17192",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22f875240369cab37842e58c9d504873643f10e1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22583)
* 11a6e3dc51a557703b1db4f1160ee6d26fb17192 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6089] Handle default insert behaviour to ingest duplicates [hudi]
Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.
wombatu-kun commented on code in PR #10728:
URL: https://github.com/apache/hudi/pull/10728#discussion_r1503671734
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -562,7 +562,7 @@ public class HoodieWriteConfig extends HoodieConfig {
public static final ConfigProperty<String> MERGE_ALLOW_DUPLICATE_ON_INSERTS_ENABLE = ConfigProperty
.key("hoodie.merge.allow.duplicate.on.inserts")
- .defaultValue("false")
+ .defaultValue("true")
.markAdvanced()
Review Comment:
done, PR is ready to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6089] Handle default insert behaviour to ingest duplicates [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10728:
URL: https://github.com/apache/hudi/pull/10728#issuecomment-1958735294
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6348547bbb296493bb2d137a9764199117784e10",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22555",
"triggerID" : "6348547bbb296493bb2d137a9764199117784e10",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6348547bbb296493bb2d137a9764199117784e10 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22555)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6089] Handle default insert behaviour to ingest duplicates [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10728:
URL: https://github.com/apache/hudi/pull/10728#issuecomment-1961247518
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6348547bbb296493bb2d137a9764199117784e10",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22555",
"triggerID" : "6348547bbb296493bb2d137a9764199117784e10",
"triggerType" : "PUSH"
}, {
"hash" : "22f875240369cab37842e58c9d504873643f10e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "22f875240369cab37842e58c9d504873643f10e1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6348547bbb296493bb2d137a9764199117784e10 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22555)
* 22f875240369cab37842e58c9d504873643f10e1 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6089] Handle default insert behaviour to ingest duplicates [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10728:
URL: https://github.com/apache/hudi/pull/10728#issuecomment-1958729214
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6348547bbb296493bb2d137a9764199117784e10",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6348547bbb296493bb2d137a9764199117784e10",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6348547bbb296493bb2d137a9764199117784e10 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6089] Handle default insert behaviour to ingest duplicates [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10728:
URL: https://github.com/apache/hudi/pull/10728#issuecomment-1963587947
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22f875240369cab37842e58c9d504873643f10e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22583",
"triggerID" : "22f875240369cab37842e58c9d504873643f10e1",
"triggerType" : "PUSH"
}, {
"hash" : "11a6e3dc51a557703b1db4f1160ee6d26fb17192",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22633",
"triggerID" : "11a6e3dc51a557703b1db4f1160ee6d26fb17192",
"triggerType" : "PUSH"
}, {
"hash" : "6ea9dfef741532eed8af624e70b0a44aae909f22",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6ea9dfef741532eed8af624e70b0a44aae909f22",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11a6e3dc51a557703b1db4f1160ee6d26fb17192 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22633)
* 6ea9dfef741532eed8af624e70b0a44aae909f22 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6089] Handle default insert behaviour to ingest duplicates [hudi]
Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.
wombatu-kun commented on code in PR #10728:
URL: https://github.com/apache/hudi/pull/10728#discussion_r1501343613
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -562,7 +562,7 @@ public class HoodieWriteConfig extends HoodieConfig {
public static final ConfigProperty<String> MERGE_ALLOW_DUPLICATE_ON_INSERTS_ENABLE = ConfigProperty
.key("hoodie.merge.allow.duplicate.on.inserts")
- .defaultValue("false")
+ .defaultValue("true")
.markAdvanced()
Review Comment:
i think there is, as people writes tasks and issues: https://github.com/apache/hudi/issues/8451
https://issues.apache.org/jira/browse/HUDI-6089
https://issues.apache.org/jira/browse/HUDI-6346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6089] Handle default insert behaviour to ingest duplicates [hudi]
Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.
wombatu-kun commented on code in PR #10728:
URL: https://github.com/apache/hudi/pull/10728#discussion_r1501343700
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -562,7 +562,7 @@ public class HoodieWriteConfig extends HoodieConfig {
public static final ConfigProperty<String> MERGE_ALLOW_DUPLICATE_ON_INSERTS_ENABLE = ConfigProperty
.key("hoodie.merge.allow.duplicate.on.inserts")
- .defaultValue("false")
+ .defaultValue("true")
.markAdvanced()
Review Comment:
i think there is, as people create tasks and issues: https://github.com/apache/hudi/issues/8451
https://issues.apache.org/jira/browse/HUDI-6089
https://issues.apache.org/jira/browse/HUDI-6346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6089] Handle default insert behaviour to ingest duplicates [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #10728:
URL: https://github.com/apache/hudi/pull/10728#discussion_r1501342711
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -562,7 +562,7 @@ public class HoodieWriteConfig extends HoodieConfig {
public static final ConfigProperty<String> MERGE_ALLOW_DUPLICATE_ON_INSERTS_ENABLE = ConfigProperty
.key("hoodie.merge.allow.duplicate.on.inserts")
- .defaultValue("false")
+ .defaultValue("true")
.markAdvanced()
Review Comment:
Is there any real use case to illustrate this switch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6089] Handle default insert behaviour to ingest duplicates [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10728:
URL: https://github.com/apache/hudi/pull/10728#issuecomment-1963228336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "22f875240369cab37842e58c9d504873643f10e1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22583",
"triggerID" : "22f875240369cab37842e58c9d504873643f10e1",
"triggerType" : "PUSH"
}, {
"hash" : "11a6e3dc51a557703b1db4f1160ee6d26fb17192",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22633",
"triggerID" : "11a6e3dc51a557703b1db4f1160ee6d26fb17192",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22f875240369cab37842e58c9d504873643f10e1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22583)
* 11a6e3dc51a557703b1db4f1160ee6d26fb17192 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22633)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6089] Handle default insert behaviour to ingest duplicates [hudi]
Posted by "bvaradar (via GitHub)" <gi...@apache.org>.
bvaradar commented on PR #10728:
URL: https://github.com/apache/hudi/pull/10728#issuecomment-1974935143
cc @nsivabalan : this needs update in documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org