You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "berkaysynnada (via GitHub)" <gi...@apache.org> on 2023/02/16 12:35:49 UTC
[GitHub] [arrow-rs] berkaysynnada opened a new pull request, #3727: Not operator overload for SortOptions
berkaysynnada opened a new pull request, #3727:
URL: https://github.com/apache/arrow-rs/pull/3727
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #3726.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
`!` operator can be used for `SortOptions` type to take reverse sort.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
`!` operator is overloaded for `SortOptions` to invert boolean fields of the struct.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #3727: Not operator overload for SortOptions
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #3727:
URL: https://github.com/apache/arrow-rs/pull/3727#issuecomment-1433578007
Benchmark runs are scheduled for baseline = 55c598d09d6268f97181e17c080d5f6a99545a4e and contender = 221533f75a0db3e4ae2bdb0b541dc37dbca2b4d3. 221533f75a0db3e4ae2bdb0b541dc37dbca2b4d3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/87fe614af0574da7b966ee265ca4ca12...4d99acd92c134bd0b3752d3e683324cf/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/1d4da7c55afc46c19c3c9318a6c839cf...415af26c316943ce98dfcc205e008dd4/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/91e80441492d4d3aa46222ebf29a98b2...0b0bd11c58fe40919dcb4d9909abb5ec/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/26cf254e225b454a99e11ccc12a18a1b...754ba8874f2a4ec887b7d8f4029f8676/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #3727: Not operator overload for SortOptions
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #3727:
URL: https://github.com/apache/arrow-rs/pull/3727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org