[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #887: Fix BE unit tests

[GitBox <gi...@apache.org>]

kangpinghuang commented on a change in pull request #887: Fix BE unit tests
URL: https://github.com/apache/incubator-doris/pull/887#discussion_r272944039
 
 

 ##########
 File path: be/src/olap/txn_manager.cpp
 ##########
 @@ -226,7 +226,7 @@ OLAPStatus TxnManager::publish_txn(OlapMeta* meta, TPartitionId partition_id, TT
         rowset_ptr->set_version_and_version_hash(version, version_hash);
         OLAPStatus save_status = RowsetMetaManager::save(meta,
             rowset_ptr->rowset_id(),
-            rowset_ptr->rowset_meta());
 
 Review comment:
   because save api  just use pointer, no need to manage the object

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org