You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by vesense <gi...@git.apache.org> on 2016/05/01 14:31:36 UTC
[GitHub] storm pull request: STORM-1754: Correct java version in 0.10.x sto...
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/1385
STORM-1754: Correct java version in 0.10.x storm-starter
Correct java version in storm-starter, because we drop supporting JDK 1.6 since Storm 0.10.0.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vesense/storm patch-24
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1385.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1385
----
commit abc47efb5b68f2400df5b85831ba288b2e6889d9
Author: Xin Wang <be...@163.com>
Date: 2016-05-01T12:25:37Z
corrent java version
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1754: Correct java version in 0.10.x sto...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/1385#issuecomment-216461066
+1 Thanks for addressing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1754: Correct java version in 0.10.x sto...
Posted by hustfxj <gi...@git.apache.org>.
Github user hustfxj commented on the pull request:
https://github.com/apache/storm/pull/1385#issuecomment-216408694
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1754: Correct java version in 0.10.x sto...
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on the pull request:
https://github.com/apache/storm/pull/1385#issuecomment-216203475
Thanks @abhishekagarwal87 Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1754: Correct java version in 0.10.x sto...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1385
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1754: Correct java version in 0.10.x sto...
Posted by dossett <gi...@git.apache.org>.
Github user dossett commented on the pull request:
https://github.com/apache/storm/pull/1385#issuecomment-216244851
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1754: Correct java version in 0.10.x sto...
Posted by abhishekagarwal87 <gi...@git.apache.org>.
Github user abhishekagarwal87 commented on the pull request:
https://github.com/apache/storm/pull/1385#issuecomment-216142879
can you add the JIRA id in commit message and update the commit message to "correct java version in documentation"? Looks good otherwise
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---