[GitHub] [bookkeeper] eolivelli commented on pull request #3357: fix journalCbQueueSize compute

[GitBox <gi...@apache.org>]

eolivelli commented on PR #3357:
URL: https://github.com/apache/bookkeeper/pull/3357#issuecomment-1177273531

   I believe that we are already computing correctly this metric.
   
   when we add a entry we increment the values, and this means that there is a callback that is waiting to be executed.
   the time we keep the callback in this "queue" is from the addEntry to the time in which we execute the callback.
   
   with this change the value will be probably always zero, because you increment the value just before requesting the actual execution of the callback to the threadpool.
   
   I believe that it is a different metric.
   
   Also I believe that the docs are correct. Because we are not interested in the queue of the threadpool that executes the callback but in the "virtual queue" that handles the callbacks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org