You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by tgroh <gi...@git.apache.org> on 2017/03/17 22:32:41 UTC

[GitHub] beam pull request #2268: [BEAM-1655] Maintain Safe-to-ACK IDs through Coder ...

GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2268

    [BEAM-1655] Maintain Safe-to-ACK IDs through Coder in PubsubIO

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    ACK them after NACKing all messages that have not been read.
    
    Remove checkStates around finalizeCheckpoint that are not consistent
    with the finalizeCheckpoint requirements.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam pubsub_io_checkpoints

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2268.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2268
    
----
commit d12b19a8fa9a917b5ffa72e38870347ec76cf71f
Author: Thomas Groh <tg...@google.com>
Date:   2017-03-17T21:57:36Z

    Maintain Safe-to-ACK IDs through Coder in PubsubIO
    
    ACK them after NACKing all messages that have not been read.
    
    Remove checkStates around finalizeCheckpoint that are not consistent
    with the finalizeCheckpoint requirements.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #2268: [BEAM-1655] Maintain Safe-to-ACK IDs through Coder ...

Posted by tgroh <gi...@git.apache.org>.
Github user tgroh closed the pull request at:

    https://github.com/apache/beam/pull/2268


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---