You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/13 09:41:51 UTC
[GitHub] [pulsar] maxsxu opened a new pull request, #16035: [fix][workflow] Update action repository path
maxsxu opened a new pull request, #16035:
URL: https://github.com/apache/pulsar/pull/16035
Signed-off-by: Max Xu <ma...@gmail.com>
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
### Motivation
Wrong action repository path.
### Modifications
Update action repository path
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [ ] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] maxsxu commented on a diff in pull request #16035: [fix][workflow] Update action repository path
Posted by GitBox <gi...@apache.org>.
maxsxu commented on code in PR #16035:
URL: https://github.com/apache/pulsar/pull/16035#discussion_r895820733
##########
.github/workflows/ci-documentbot.yml:
##########
@@ -29,15 +29,14 @@ on:
jobs:
label:
- if: ${{ github.repository == 'apache/pulsar' }}
Review Comment:
@lhotari Thanks for your review and great care!
I've reverted this removal, which was introduced during my test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #16035: [fix][workflow] Update action repository path
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16035:
URL: https://github.com/apache/pulsar/pull/16035#issuecomment-1154581711
@maxsxu Please provide a correct documentation label for your PR.
Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a diff in pull request #16035: [fix][workflow] Update action repository path
Posted by GitBox <gi...@apache.org>.
lhotari commented on code in PR #16035:
URL: https://github.com/apache/pulsar/pull/16035#discussion_r895787546
##########
.github/workflows/ci-documentbot.yml:
##########
@@ -29,15 +29,14 @@ on:
jobs:
label:
- if: ${{ github.repository == 'apache/pulsar' }}
Review Comment:
some developers would like to run CI jobs in their own forks without any bots running. That's the reason why you shouldn't remove this rule.
https://github.com/apache/pulsar/pull/15535 contains instructions for running a "personal CI". unfortunately those instructions are missing from the new website.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall merged pull request #16035: [fix][workflow] Update action repository path
Posted by GitBox <gi...@apache.org>.
michaeljmarshall merged PR #16035:
URL: https://github.com/apache/pulsar/pull/16035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a diff in pull request #16035: [fix][workflow] Update action repository path
Posted by GitBox <gi...@apache.org>.
lhotari commented on code in PR #16035:
URL: https://github.com/apache/pulsar/pull/16035#discussion_r895844320
##########
.github/workflows/ci-documentbot.yml:
##########
@@ -29,15 +29,14 @@ on:
jobs:
label:
- if: ${{ github.repository == 'apache/pulsar' }}
Review Comment:
thanks for addressing the issue @maxsxu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a diff in pull request #16035: [fix][workflow] Update action repository path
Posted by GitBox <gi...@apache.org>.
lhotari commented on code in PR #16035:
URL: https://github.com/apache/pulsar/pull/16035#discussion_r895741670
##########
.github/workflows/ci-documentbot.yml:
##########
@@ -29,15 +29,14 @@ on:
jobs:
label:
- if: ${{ github.repository == 'apache/pulsar' }}
Review Comment:
this shouldn't be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org