[GitHub] [skywalking] hanahmily commented on pull request #5099: Storage elasticsearch health check

[GitBox <gi...@apache.org>]

hanahmily commented on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-660649698


   @wu-sheng I enclose the gauge value into a new metric class, HealthCheckMetrics, so other developers don't have to set the value directly. 
   
   But when I try to move the initialization of the client to the start phase, some other module, for instance, CoreModule, complains they can't find the service provided by Storage modules. It seems we must keep the registration of storage service in the `prepare` phase. So I add a new DeletegatedHealthChecker as a final field of client classes, it can receive the HealthChecker created by Telemetry module, that's available in the start phase.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org