[GitHub] [zeppelin] huage1994 commented on a diff in pull request #4463: [ZEPPELIN-5493] Remove prefix in jdbc interpreter

[GitBox <gi...@apache.org>]

huage1994 commented on code in PR #4463:
URL: https://github.com/apache/zeppelin/pull/4463#discussion_r985214869


##########
jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java:
##########
@@ -550,9 +549,9 @@ public Connection getConnection(String dbPrefix, InterpreterContext context)
         LOGGER.debug("createSecureConfiguration() returned");
         boolean isProxyEnabled = Boolean.parseBoolean(
                 getProperty("zeppelin.jdbc.auth.kerberos.proxy.enable", "true"));
-        if (basePropertiesMap.get(dbPrefix).containsKey("proxy.user.property")
+        if (basePropertiesMap.get(DEFAULT_KEY).containsKey("proxy.user.property")

Review Comment:
   > BTW, can we change `basePropertiesMap` not to use DEFAULT_KEY as a key?
   
   Hi @jongyoul ,I totally agree with you.  
   I plan to refactor `JDBC` module  in the very soon future.  
   
   As I was developing, I realized that removing `basePropertiesMap` would require a significant code change. I don't want this PR to get too big , so I plan to refactor `JDBC` module in another PR.  
   
   
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org