You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/27 21:30:50 UTC
[GitHub] [kafka] vitojeng opened a new pull request #8939: MINOR: rename class `RecordTimeDefintion` to `RecordTimeDefinition`
vitojeng opened a new pull request #8939:
URL: https://github.com/apache/kafka/pull/8939
The naming of internal class `RecordTimeDefintion` in streams module should be a typo.
This PR fix it to `RecordTimeDefinition`.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] abbccdda commented on pull request #8939: MINOR: rename class `RecordTimeDefintion` to `RecordTimeDefinition`
Posted by GitBox <gi...@apache.org>.
abbccdda commented on pull request #8939:
URL: https://github.com/apache/kafka/pull/8939#issuecomment-654346340
Confirmed only known flaky tests are failing. Merging
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vitojeng commented on pull request #8939: MINOR: rename class `RecordTimeDefintion` to `RecordTimeDefinition`
Posted by GitBox <gi...@apache.org>.
vitojeng commented on pull request #8939:
URL: https://github.com/apache/kafka/pull/8939#issuecomment-654551605
Thanks @abbccdda !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] abbccdda merged pull request #8939: MINOR: rename class `RecordTimeDefintion` to `RecordTimeDefinition`
Posted by GitBox <gi...@apache.org>.
abbccdda merged pull request #8939:
URL: https://github.com/apache/kafka/pull/8939
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] abbccdda commented on pull request #8939: MINOR: rename class `RecordTimeDefintion` to `RecordTimeDefinition`
Posted by GitBox <gi...@apache.org>.
abbccdda commented on pull request #8939:
URL: https://github.com/apache/kafka/pull/8939#issuecomment-654039914
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] abbccdda commented on pull request #8939: MINOR: rename class `RecordTimeDefintion` to `RecordTimeDefinition`
Posted by GitBox <gi...@apache.org>.
abbccdda commented on pull request #8939:
URL: https://github.com/apache/kafka/pull/8939#issuecomment-653364949
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org