You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@arrow.apache.org by "David Li (Jira)" <ji...@apache.org> on 2022/06/15 14:03:00 UTC

[jira] [Commented] (ARROW-16836) [C++] Have exported ArrowArrayStreams call RecordBatchReader::Close

    [ https://issues.apache.org/jira/browse/ARROW-16836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554617#comment-17554617 ] 

David Li commented on ARROW-16836:
----------------------------------

CC [~vibhatha] [~westonpace]

> [C++] Have exported ArrowArrayStreams call RecordBatchReader::Close
> -------------------------------------------------------------------
>
>                 Key: ARROW-16836
>                 URL: https://issues.apache.org/jira/browse/ARROW-16836
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: David Li
>            Priority: Major
>
> We added RecordBatchReader::Close(), should we have an exported ArrowArrayStream call this? 
> The issue is that {{release()}} can't return errors. We could call {{Close()}} implicitly after the last batch if the user drains the ArrowArrayStream, and return any error there, but if they don't drain the stream (but call {{release}}) we'll have no way to return the error. (Or we could make an ABI break…)



--
This message was sent by Atlassian Jira
(v8.20.7#820007)