You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Matt Ryan (JIRA)" <ji...@apache.org> on 2018/09/25 21:24:00 UTC
[jira] [Commented] (OAK-7718) [DataStore] Refactor cloud data
stores for better code reuse
[ https://issues.apache.org/jira/browse/OAK-7718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627953#comment-16627953 ]
Matt Ryan commented on OAK-7718:
--------------------------------
I've created [https://github.com/mattvryan/jackrabbit-oak/pull/16] to start the review. It splits {{oak-blob-cloud-s3}} out and creates {{oak-blob-cloud}} as a baseline cloud data store module where common code can be shared, and it creates a common base class for the service class in both cloud implementations. [~amitjain] when you have a minute please take a look, I'd like to do this with your review to make sure we don't miss anything.
> [DataStore] Refactor cloud data stores for better code reuse
> ------------------------------------------------------------
>
> Key: OAK-7718
> URL: https://issues.apache.org/jira/browse/OAK-7718
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: blob-cloud, blob-cloud-azure
> Reporter: Matt Ryan
> Assignee: Matt Ryan
> Priority: Major
>
> Refactor the cloud data stores so that we can reuse code between them.
> Currently {{oak-blob-cloud}} exists for {{S3DataStore}} and {{oak-blob-cloud-azure}} for {{AzureDataStore}}. There's no common codebase between them, other than {{oak-blob-plugins}} which seems a bit too broad for sharing code between the cloud data stores.
> The proposal is to repurpose {{oak-blob-cloud}} into common code for all cloud data stores, create {{oak-blob-cloud-s3}} for {{S3DataStore}}, and then move what common code that can be shared between the two into the new {{oak-blob-cloud}} module.
> This also would allow us to share testing code, which could be important especially for creating a cloud storage mock that will enable CI testing on the cloud data stores.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)