Re: [PR] CASSANDRASC-91 Returning when AbstractHandler encounters exception while extracting params from the request. [cassandra-sidecar]

["yifan-c (via GitHub)" <gi...@apache.org>]

yifan-c commented on code in PR #88:
URL: https://github.com/apache/cassandra-sidecar/pull/88#discussion_r1440735224


##########
src/main/java/org/apache/cassandra/sidecar/routes/AbstractHandler.java:
##########
@@ -93,6 +93,7 @@ public void handle(RoutingContext context)
         catch (Exception exception)
         {
             processFailure(exception, context, host, remoteAddress, null);
+            return;

Review Comment:
   Instead of `return` from the catch block, how about moving the `handleInternal` call inside the try block? So that it catches any exception throw during `handleInternal`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org