[GitHub] [incubator-superset] kkucharc commented on a change in pull request #11131: test: removed unicode_test example from unit tests

[GitBox <gi...@apache.org>]

kkucharc commented on a change in pull request #11131:
URL: https://github.com/apache/incubator-superset/pull/11131#discussion_r499522989



##########
File path: tests/security_tests.py
##########
@@ -1122,6 +1132,41 @@ def test_rls_filter_doesnt_alter_energy_query(self):
         assert tbl.get_extra_cache_keys(self.query_obj) == []
         assert "value > 1" not in sql
 
+    @pytest.fixture()
+    def load_unicode_dashboard(self):

Review comment:
       Sounds good. I just wanted to clarify if you mean moving to `fixtures/` directory? My only concern is about some fixtures that create slices for dashboards (or some other setup). I wondered if wouldn't be better to have just some common parts to combine those dashboard creation parts into particular fixtures (as there is this new file `dashboard_utils`. Or maybe having basic fixture which will be extended or decorated in more complex cases?  WDYT @villebro ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org