You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by pengcheng xiong <px...@hortonworks.com> on 2014/08/08 09:26:32 UTC
Review Request 24498: A method to extrapolate the missing column status for
the partitions.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24498/
-----------------------------------------------------------
Review request for hive.
Repository: hive-git
Description
-------
We propose a method to extrapolate the missing column status for the partitions.
Diffs
-----
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 43c412d
Diff: https://reviews.apache.org/r/24498/diff/
Testing
-------
Thanks,
pengcheng xiong
Re: Review Request 24498: A method to extrapolate the missing column
status for the partitions.
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24498/#review51109
-----------------------------------------------------------
Patch does a great job of making # of queries independent of # of columns. Good work! But it seems its now making queries over all partitions of table, instead of those listed in request.
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/24498/#comment89121>
Now that you have fixed this TODO, you can delete it.
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
<https://reviews.apache.org/r/24498/#comment89114>
This should contain " and PARTITION_NAME in ()" otherwise we are running query over all partitions of table, instead of those requested.
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
<https://reviews.apache.org/r/24498/#comment89117>
This should contain " and PARTITION_NAME in ()" otherwise we are running query over all partitions of table, instead of those requested.
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
<https://reviews.apache.org/r/24498/#comment89118>
This should contain " and PARTITION_NAME in ()" otherwise we are running query over all partitions of table, instead of those requested.
- Ashutosh Chauhan
On Aug. 20, 2014, 6:52 a.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24498/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2014, 6:52 a.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> We propose a method to extrapolate the missing column status for the partitions.
>
>
> Diffs
> -----
>
> data/files/extrapolate_stats_full.txt PRE-CREATION
> data/files/extrapolate_stats_partial.txt PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 84ef5f9
> metastore/src/java/org/apache/hadoop/hive/metastore/IExtrapolatePartStatus.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/LinearExtrapolatePartStatus.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 767cffc
> metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java a9f4be2
> metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 0364385
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 4eba2b0
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 78ab19a
> ql/src/test/queries/clientpositive/extrapolate_part_stats_full.q PRE-CREATION
> ql/src/test/queries/clientpositive/extrapolate_part_stats_partial.q PRE-CREATION
> ql/src/test/results/clientpositive/extrapolate_part_stats_full.q.out PRE-CREATION
> ql/src/test/results/clientpositive/extrapolate_part_stats_partial.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/24498/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> HIVE-7654.0.patch
> https://reviews.apache.org/media/uploaded/files/2014/08/12/77b155b0-a417-4225-b6b7-4c8c6ce2b97d__HIVE-7654.0.patch
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 24498: A method to extrapolate the missing column
status for the partitions.
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24498/
-----------------------------------------------------------
(Updated Aug. 22, 2014, 5:45 p.m.)
Review request for hive.
Changes
-------
address the partial test case error
Repository: hive-git
Description
-------
We propose a method to extrapolate the missing column status for the partitions.
Diffs (updated)
-----
data/files/extrapolate_stats_full.txt PRE-CREATION
data/files/extrapolate_stats_partial.txt PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 9489949
metastore/src/java/org/apache/hadoop/hive/metastore/IExtrapolatePartStatus.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/LinearExtrapolatePartStatus.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 767cffc
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java a9f4be2
metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 0364385
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 4eba2b0
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 78ab19a
ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java 8100b39
ql/src/test/queries/clientpositive/extrapolate_part_stats_full.q PRE-CREATION
ql/src/test/queries/clientpositive/extrapolate_part_stats_partial.q PRE-CREATION
ql/src/test/results/clientpositive/annotate_stats_part.q.out 10993c3
ql/src/test/results/clientpositive/extrapolate_part_stats_full.q.out PRE-CREATION
ql/src/test/results/clientpositive/extrapolate_part_stats_partial.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/24498/diff/
Testing
-------
File Attachments
----------------
HIVE-7654.0.patch
https://reviews.apache.org/media/uploaded/files/2014/08/12/77b155b0-a417-4225-b6b7-4c8c6ce2b97d__HIVE-7654.0.patch
Thanks,
pengcheng xiong
Re: Review Request 24498: A method to extrapolate the missing column
status for the partitions.
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24498/
-----------------------------------------------------------
(Updated Aug. 20, 2014, 8:55 p.m.)
Review request for hive.
Changes
-------
fix the annotation test error
Repository: hive-git
Description
-------
We propose a method to extrapolate the missing column status for the partitions.
Diffs (updated)
-----
data/files/extrapolate_stats_full.txt PRE-CREATION
data/files/extrapolate_stats_partial.txt PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 84ef5f9
metastore/src/java/org/apache/hadoop/hive/metastore/IExtrapolatePartStatus.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/LinearExtrapolatePartStatus.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 767cffc
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java a9f4be2
metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 0364385
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 4eba2b0
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 78ab19a
ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java 8100b39
ql/src/test/queries/clientpositive/extrapolate_part_stats_full.q PRE-CREATION
ql/src/test/queries/clientpositive/extrapolate_part_stats_partial.q PRE-CREATION
ql/src/test/results/clientpositive/annotate_stats_part.q.out 10993c3
ql/src/test/results/clientpositive/extrapolate_part_stats_full.q.out PRE-CREATION
ql/src/test/results/clientpositive/extrapolate_part_stats_partial.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/24498/diff/
Testing
-------
File Attachments
----------------
HIVE-7654.0.patch
https://reviews.apache.org/media/uploaded/files/2014/08/12/77b155b0-a417-4225-b6b7-4c8c6ce2b97d__HIVE-7654.0.patch
Thanks,
pengcheng xiong
Re: Review Request 24498: A method to extrapolate the missing column
status for the partitions.
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24498/
-----------------------------------------------------------
(Updated Aug. 20, 2014, 6:52 a.m.)
Review request for hive.
Changes
-------
reduce # of queries follow Ashutosh's comments
Repository: hive-git
Description
-------
We propose a method to extrapolate the missing column status for the partitions.
Diffs (updated)
-----
data/files/extrapolate_stats_full.txt PRE-CREATION
data/files/extrapolate_stats_partial.txt PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 84ef5f9
metastore/src/java/org/apache/hadoop/hive/metastore/IExtrapolatePartStatus.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/LinearExtrapolatePartStatus.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 767cffc
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java a9f4be2
metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 0364385
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 4eba2b0
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 78ab19a
ql/src/test/queries/clientpositive/extrapolate_part_stats_full.q PRE-CREATION
ql/src/test/queries/clientpositive/extrapolate_part_stats_partial.q PRE-CREATION
ql/src/test/results/clientpositive/extrapolate_part_stats_full.q.out PRE-CREATION
ql/src/test/results/clientpositive/extrapolate_part_stats_partial.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/24498/diff/
Testing
-------
File Attachments
----------------
HIVE-7654.0.patch
https://reviews.apache.org/media/uploaded/files/2014/08/12/77b155b0-a417-4225-b6b7-4c8c6ce2b97d__HIVE-7654.0.patch
Thanks,
pengcheng xiong
Re: Review Request 24498: A method to extrapolate the missing column
status for the partitions.
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24498/#review50938
-----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/IExtrapolatePartStatus.java
<https://reviews.apache.org/r/24498/#comment88831>
Needs apache license header. Look at top of any other java file.
metastore/src/java/org/apache/hadoop/hive/metastore/IExtrapolatePartStatus.java
<https://reviews.apache.org/r/24498/#comment88832>
Better name: AggrType?
metastore/src/java/org/apache/hadoop/hive/metastore/LinearExtrapolatePartStatus.java
<https://reviews.apache.org/r/24498/#comment88835>
Apache header?
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
<https://reviews.apache.org/r/24498/#comment88821>
It will be good if this api also returns count for # of partitions for which stats were found.
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
<https://reviews.apache.org/r/24498/#comment88822>
I think checking total == (# of cols) * (# of parts) is better.
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
<https://reviews.apache.org/r/24498/#comment88829>
We are doing 3 queries per column. We need to do better here. e.g if there are 20 columns in table. We will end up with 60 queries. Tables with few hundred columns are not unheard of.
Seems like query for column type can be avoided altogether, since column names are sent from client, we can also send type info from client, since client already has it.
For other queries, also we need to make it independent of # of columns.
ql/src/test/queries/clientpositive/extrapolate_part_stats.q
<https://reviews.apache.org/r/24498/#comment88830>
Why do you have this flag set to false? Unless, there is a reason take this off.
- Ashutosh Chauhan
On Aug. 17, 2014, 4:23 a.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24498/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2014, 4:23 a.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> We propose a method to extrapolate the missing column status for the partitions.
>
>
> Diffs
> -----
>
> metastore/src/java/org/apache/hadoop/hive/metastore/IExtrapolatePartStatus.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/LinearExtrapolatePartStatus.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 767cffc
> ql/src/test/queries/clientpositive/extrapolate_part_stats.q PRE-CREATION
> ql/src/test/results/clientpositive/extrapolate_part_stats.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/24498/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> HIVE-7654.0.patch
> https://reviews.apache.org/media/uploaded/files/2014/08/12/77b155b0-a417-4225-b6b7-4c8c6ce2b97d__HIVE-7654.0.patch
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 24498: A method to extrapolate the missing column
status for the partitions.
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24498/
-----------------------------------------------------------
(Updated Aug. 17, 2014, 4:23 a.m.)
Review request for hive.
Changes
-------
update the test file
Repository: hive-git
Description
-------
We propose a method to extrapolate the missing column status for the partitions.
Diffs (updated)
-----
metastore/src/java/org/apache/hadoop/hive/metastore/IExtrapolatePartStatus.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/LinearExtrapolatePartStatus.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 767cffc
ql/src/test/queries/clientpositive/extrapolate_part_stats.q PRE-CREATION
ql/src/test/results/clientpositive/extrapolate_part_stats.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/24498/diff/
Testing
-------
File Attachments
----------------
HIVE-7654.0.patch
https://reviews.apache.org/media/uploaded/files/2014/08/12/77b155b0-a417-4225-b6b7-4c8c6ce2b97d__HIVE-7654.0.patch
Thanks,
pengcheng xiong
Re: Review Request 24498: A method to extrapolate the missing column status
for the partitions.
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24498/
-----------------------------------------------------------
(Updated Aug. 13, 2014, 8:54 p.m.)
Review request for hive.
Changes
-------
address comments from Sergy. Also add test cases.
Repository: hive-git
Description
-------
We propose a method to extrapolate the missing column status for the partitions.
Diffs (updated)
-----
metastore/src/java/org/apache/hadoop/hive/metastore/IExtrapolatePartStatus.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/LinearExtrapolatePartStatus.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 767cffc
ql/src/test/queries/clientpositive/extrapolate_part_stats.q PRE-CREATION
ql/src/test/results/clientpositive/extrapolate_part_stats.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/24498/diff/
Testing
-------
File Attachments
----------------
HIVE-7654.0.patch
https://reviews.apache.org/media/uploaded/files/2014/08/12/77b155b0-a417-4225-b6b7-4c8c6ce2b97d__HIVE-7654.0.patch
Thanks,
pengcheng xiong
Re: Review Request 24498: A method to extrapolate the missing column status
for the partitions.
Posted by pengcheng xiong <px...@hortonworks.com>.
> On Aug. 13, 2014, 1:10 a.m., Sergey Shelukhin wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java, line 1101
> > <https://reviews.apache.org/r/24498/diff/2/?file=658642#file658642line1101>
> >
> > please quote the identifier names (won't work on pgsql otherwise) and use parameters for parameters
Sorry, could you please give an example of "use parameters for parameters"? Thanks!
- pengcheng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24498/#review50392
-----------------------------------------------------------
On Aug. 13, 2014, 8:54 p.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24498/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2014, 8:54 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> We propose a method to extrapolate the missing column status for the partitions.
>
>
> Diffs
> -----
>
> metastore/src/java/org/apache/hadoop/hive/metastore/IExtrapolatePartStatus.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/LinearExtrapolatePartStatus.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 767cffc
> ql/src/test/queries/clientpositive/extrapolate_part_stats.q PRE-CREATION
> ql/src/test/results/clientpositive/extrapolate_part_stats.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/24498/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> HIVE-7654.0.patch
> https://reviews.apache.org/media/uploaded/files/2014/08/12/77b155b0-a417-4225-b6b7-4c8c6ce2b97d__HIVE-7654.0.patch
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 24498: A method to extrapolate the missing column
status for the partitions.
Posted by Sergey Shelukhin <se...@hortonworks.com>.
> On Aug. 13, 2014, 1:10 a.m., Sergey Shelukhin wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java, line 1101
> > <https://reviews.apache.org/r/24498/diff/2/?file=658642#file658642line1101>
> >
> > please quote the identifier names (won't work on pgsql otherwise) and use parameters for parameters
>
> pengcheng xiong wrote:
> Sorry, could you please give an example of "use parameters for parameters"? Thanks!
See many other queries where "?"s are used w/parameters array (in the same file)
- Sergey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24498/#review50392
-----------------------------------------------------------
On Aug. 17, 2014, 4:23 a.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24498/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2014, 4:23 a.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> We propose a method to extrapolate the missing column status for the partitions.
>
>
> Diffs
> -----
>
> metastore/src/java/org/apache/hadoop/hive/metastore/IExtrapolatePartStatus.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/LinearExtrapolatePartStatus.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 767cffc
> ql/src/test/queries/clientpositive/extrapolate_part_stats.q PRE-CREATION
> ql/src/test/results/clientpositive/extrapolate_part_stats.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/24498/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> HIVE-7654.0.patch
> https://reviews.apache.org/media/uploaded/files/2014/08/12/77b155b0-a417-4225-b6b7-4c8c6ce2b97d__HIVE-7654.0.patch
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 24498: A method to extrapolate the missing column status
for the partitions.
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24498/#review50392
-----------------------------------------------------------
There's no JDO path at all. Is this intended?
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
<https://reviews.apache.org/r/24498/#comment88164>
whitespace here and further on
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
<https://reviews.apache.org/r/24498/#comment88165>
this common part of the query could be moved to constant
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
<https://reviews.apache.org/r/24498/#comment88166>
please quote the identifier names (won't work on pgsql otherwise) and use parameters for parameters
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
<https://reviews.apache.org/r/24498/#comment88167>
I wonder if so much logic belongs to DirectSQL class; it is growing pretty big. Maybe it can be moved out
- Sergey Shelukhin
On Aug. 12, 2014, 5:57 p.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24498/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2014, 5:57 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> We propose a method to extrapolate the missing column status for the partitions.
>
>
> Diffs
> -----
>
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 43c412d
>
> Diff: https://reviews.apache.org/r/24498/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> HIVE-7654.0.patch
> https://reviews.apache.org/media/uploaded/files/2014/08/12/77b155b0-a417-4225-b6b7-4c8c6ce2b97d__HIVE-7654.0.patch
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 24498: A method to extrapolate the missing column status
for the partitions.
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24498/
-----------------------------------------------------------
(Updated Aug. 12, 2014, 5:57 p.m.)
Review request for hive.
Changes
-------
the first patch
Repository: hive-git
Description
-------
We propose a method to extrapolate the missing column status for the partitions.
Diffs (updated)
-----
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 43c412d
Diff: https://reviews.apache.org/r/24498/diff/
Testing
-------
File Attachments
----------------
HIVE-7654.0.patch
https://reviews.apache.org/media/uploaded/files/2014/08/12/77b155b0-a417-4225-b6b7-4c8c6ce2b97d__HIVE-7654.0.patch
Thanks,
pengcheng xiong
Re: Review Request 24498: A method to extrapolate the missing column status
for the partitions.
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24498/
-----------------------------------------------------------
(Updated Aug. 12, 2014, 5:08 p.m.)
Review request for hive.
Changes
-------
A method to extrapolate the missing column status for the partitions (1st patch)
Repository: hive-git
Description
-------
We propose a method to extrapolate the missing column status for the partitions.
Diffs
-----
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 43c412d
Diff: https://reviews.apache.org/r/24498/diff/
Testing
-------
File Attachments (updated)
----------------
HIVE-7654.0.patch
https://reviews.apache.org/media/uploaded/files/2014/08/12/77b155b0-a417-4225-b6b7-4c8c6ce2b97d__HIVE-7654.0.patch
Thanks,
pengcheng xiong