You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/29 14:59:46 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30179: [SPARK-33283][CORE] Remove useless externalBlockStoreSize from RDDInfo

dongjoon-hyun commented on a change in pull request #30179:
URL: https://github.com/apache/spark/pull/30179#discussion_r514327006



##########
File path: core/src/main/scala/org/apache/spark/rdd/RDD.scala
##########
@@ -1919,9 +1919,8 @@ abstract class RDD[T: ClassTag](
 
       val persistence = if (storageLevel != StorageLevel.NONE) storageLevel.description else ""
       val storageInfo = rdd.context.getRDDStorageInfo(_.id == rdd.id).map(info =>
-        "    CachedPartitions: %d; MemorySize: %s; ExternalBlockStoreSize: %s; DiskSize: %s".format(
-          info.numCachedPartitions, bytesToString(info.memSize),
-          bytesToString(info.externalBlockStoreSize), bytesToString(info.diskSize)))
+        "    CachedPartitions: %d; MemorySize: %s; DiskSize: %s".format(
+          info.numCachedPartitions, bytesToString(info.memSize), bytesToString(info.diskSize)))

Review comment:
       Since it was removed at `toString`, it's okay to remove it from `toDebugString`.
   - https://github.com/apache/spark/pull/10752/files#diff-e49db126594e91593208902e13961dc09524442090801f4d6cfce7c43da13c72R42-R48




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org